New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retroactive posse #1190

Merged
merged 14 commits into from Feb 5, 2016

Conversation

Projects
None yet
6 participants
@matzoman
Contributor

matzoman commented Feb 3, 2016

#206

Adding the possibility to POSSE an entry in edit mode. The syndication toggles are disabled when the entry was POSSE'd already. (Disabling only works when the twitter/fb/etc. plugin adds the Entity::setPosseLinks parameter 'account_id'.)

major changes:

  • a new Entity::publish() function all plugins must use for the button "Publish".
  • the function Template::drawSyndication() has a new parameter (the return value of Entity::getPosseLinks())

I changed all plugins to use publish() and added the new parameter to all drawSyndication calls.

matzoman added some commits Jan 22, 2016

Update Endpoint.php
adding support for syndication tag
add support for 'syndication' in micropub endpoint
name of service is determined with parseUrl
added Entity::publish
Entity::publish is replacing Entity::save for publishing something. All
plug-ins are modified.

(not sure about classes: RemoteUser, RemoteObject, Notification,
GenericDataItem)
Revert "Merge remote-tracking branch 'refs/remotes/origin/matzoman-pa…
…tch-endpoint'"

This reverts commit f65ce53, reversing
changes made to ba73ef7.

removing unrelated changes in Endpoint
disable posse button if POSSE'd
this commit only changes the photo plugin
always show syndication buttons
removed check for id and added second parameter for
Template::drawSyndication
cleanup for disable toggle
searching in posseLinks array if entry is already POSSE'd
@physcocode

This comment has been minimized.

Show comment
Hide comment
@physcocode

physcocode Feb 3, 2016

Contributor

wow this is blowing my mind 👍

Contributor

physcocode commented Feb 3, 2016

wow this is blowing my mind 👍

@kylewm

This comment has been minimized.

Show comment
Hide comment
@kylewm

kylewm Feb 3, 2016

Collaborator

Insert that Tim and Eric mind blowing gif. Just checked this out on my install, and it works beautifully! Nicely done!

Collaborator

kylewm commented Feb 3, 2016

Insert that Tim and Eric mind blowing gif. Just checked this out on my install, and it works beautifully! Nicely done!

@benwerd

This comment has been minimized.

Show comment
Hide comment
@benwerd

benwerd Feb 3, 2016

Member

I'm really looking forward to trying this out! Amazing work!

On Wednesday, February 3, 2016, Kyle Mahan notifications@github.com wrote:

Insert that Tim and Eric mind blowing gif. Just checked this out on my
install, and it works beautifully! Nicely done!


Reply to this email directly or view it on GitHub
#1190 (comment).

Ben Werdmuller
http://goog_1933028737
benwerd.com | werd.io

+1 (312) 488-9373

Member

benwerd commented Feb 3, 2016

I'm really looking forward to trying this out! Amazing work!

On Wednesday, February 3, 2016, Kyle Mahan notifications@github.com wrote:

Insert that Tim and Eric mind blowing gif. Just checked this out on my
install, and it works beautifully! Nicely done!


Reply to this email directly or view it on GitHub
#1190 (comment).

Ben Werdmuller
http://goog_1933028737
benwerd.com | werd.io

+1 (312) 488-9373

benwerd added a commit that referenced this pull request Feb 5, 2016

@benwerd benwerd merged commit d685c6a into idno:master Feb 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benwerd

This comment has been minimized.

Show comment
Hide comment
@benwerd

benwerd Feb 5, 2016

Member

Awesome!

Member

benwerd commented Feb 5, 2016

Awesome!

@kylewm

This comment has been minimized.

Show comment
Hide comment
@kylewm

kylewm Feb 6, 2016

Collaborator

@matzoman Could you make this bit conditional, so it only calls setPosseLink if posse_link is non-null?

FYI, you can also use parse_url($posse_link, PHP_URL_HOST) to get the host directly rather than the fully parsed URL.

Collaborator

kylewm commented on f9d92fa Feb 6, 2016

@matzoman Could you make this bit conditional, so it only calls setPosseLink if posse_link is non-null?

FYI, you can also use parse_url($posse_link, PHP_URL_HOST) to get the host directly rather than the fully parsed URL.

This comment has been minimized.

Show comment
Hide comment
@matzoman

matzoman Feb 8, 2016

Contributor

yes, the call should be conditional!

Contributor

matzoman replied Feb 8, 2016

yes, the call should be conditional!

@kylewm

This comment has been minimized.

Show comment
Hide comment
@kylewm

kylewm Feb 6, 2016

Collaborator

It's worth noting that now Entity::saveDataFromInput calls Entity::publish which calls Entity::save, which isn't super intuitive. Would it be worth renaming saveDataFromInput? publishDataFromInput doesn't make much sense; maybe processFormInput or something??

Granted renaming across plugins is a pain, but if we're going to do it might as well do it now.

Collaborator

kylewm commented Feb 6, 2016

It's worth noting that now Entity::saveDataFromInput calls Entity::publish which calls Entity::save, which isn't super intuitive. Would it be worth renaming saveDataFromInput? publishDataFromInput doesn't make much sense; maybe processFormInput or something??

Granted renaming across plugins is a pain, but if we're going to do it might as well do it now.

@matzoman

This comment has been minimized.

Show comment
Hide comment
@matzoman

matzoman Feb 8, 2016

Contributor

Thanks for all the kind words! It is a really engaging atmosphere in this project..

Contributor

matzoman commented Feb 8, 2016

Thanks for all the kind words! It is a really engaging atmosphere in this project..

@danito

This comment has been minimized.

Show comment
Hide comment
@danito

danito Feb 9, 2016

Contributor

👍
Just my feature request: can we change the colour of an already syndicated service? When I hit edit now, I don't know if I already have pushed it to tw or FB (without checking first), is there an easy way to change the grey toggle to maybe black or orange where the posse link exists?

Contributor

danito commented Feb 9, 2016

👍
Just my feature request: can we change the colour of an already syndicated service? When I hit edit now, I don't know if I already have pushed it to tw or FB (without checking first), is there an easy way to change the grey toggle to maybe black or orange where the posse link exists?

@matzoman matzoman deleted the matzoman:Retroactive-posse branch Feb 9, 2016

@srcr

This comment has been minimized.

Show comment
Hide comment
@srcr

srcr Feb 11, 2016

Contributor

Awesome feature, thank @matzoman +1

Contributor

srcr commented Feb 11, 2016

Awesome feature, thank @matzoman +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment