Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console debug #1617

Merged
merged 8 commits into from Dec 20, 2016

Conversation

Projects
None yet
3 participants
@mapkyca
Copy link
Member

commented Dec 19, 2016

Here's what I fixed or added:

  • Gave the Known Console a bit of a polish
  • Made known.php load a minimal Known core boot
  • Introduced the ConsolePlugin class to simplify console plugin writes
  • Made known.php use class loaders to load console plugins
  • Added an example plugin, and a basic debug plugin

Here's why I did it:

I needed to start building out some debug tools to help with development

@mapkyca mapkyca requested a review from benwerd Dec 19, 2016

@physcocode

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2016

This is defiantly what i wanna see merging in core then maybe i can make a console plugin to build a bare plugin for known ! something like what artisan in laravel does !

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Dec 20, 2016

I've moved the potentially risky plugin to its own dev repo, so merging in the core, which I think is fairly safe (since it was broken before, so I figure nobody was actually using it!)

@mapkyca mapkyca merged commit 9b4dd41 into idno:master Dec 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lindner

This comment has been minimized.

Copy link
Contributor

commented on known.php in 8dceeeb Dec 27, 2018

This breaks vimeo embeds. You need to configure a safe list of iframe URL sources.

See https://1500wordmtu.com/2018/when-pong-played-humans for a mangled entry.

This comment has been minimized.

Copy link
Contributor

replied Dec 31, 2018

Actually looks like all iframes are getting escaped..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.