New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly check type when sending annotation via micropub #1936

Merged
merged 2 commits into from Nov 1, 2017

Conversation

Projects
None yet
2 participants
@cweiske
Contributor

cweiske commented Oct 30, 2017

Also throw the error correctly.

Here's what I fixed or added:

  • Check if the annotation type is correct
  • Call the wrong-type-error function with the correct number of arguments
  • Fetch post by slug not UUID, that does not work anymore.

Here's why I did it:

Adding annotations via micropub (#1535) was broken.

cweiske added some commits Oct 30, 2017

Fetch posts by slug from database, not via UUID.
Last year the UUID was the post URL, but that changed.
Now we have to extract the slug from the URL and search the
post by slug.

@mapkyca mapkyca merged commit bccfc4a into idno:master Nov 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mapkyca

This comment has been minimized.

Show comment
Hide comment
@mapkyca

mapkyca Nov 1, 2017

Collaborator

Thanks for the fix!

Collaborator

mapkyca commented Nov 1, 2017

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment