Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove token debug #2069

Merged
merged 4 commits into from Apr 13, 2018

Conversation

Projects
None yet
2 participants
@mapkyca
Copy link
Member

mapkyca commented Apr 13, 2018

Here's what I fixed or added:

Removing the token debug logging

Here's why I did it:

The situation that needed this has been resolved, and logs that are too verbose are hard to read.

mapkyca added some commits Apr 9, 2018

Adding diagnostics for detecting the latest version off of github.
Attempting a more responsive mechanism for detecting new releases of Known, this time keying off GitHub.

This is designed to be temporary, and not to replace the official release/update notification.
Merge branch 'master' of git://github.com/idno/idno
# Conflicts:
#	Idno/Pages/Admin/Diagnostics.php
Removing token debugging for quieter logs
The situation which necessitated the addition of this logging has now been resolved. For quieter debug logs, remove this logging until a situation arrises when it is needed again.

@mapkyca mapkyca merged commit ab6181a into idno:master Apr 13, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@srcr

This comment has been minimized.

Copy link
Contributor

srcr commented Apr 18, 2018

Would it be an idea to do the same for the file Idno/Pages/Service/Security/CSRFToken.php line 16, this one is still generating CSRF token debug info.

@mapkyca

This comment has been minimized.

Copy link
Member Author

mapkyca commented Apr 25, 2018

Ahh... good spot, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.