Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Micropub] Photo posts not containing proper photo link anymore, but inlined HTML image instead #2138

Closed
skddc opened this Issue Aug 31, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@skddc
Copy link

skddc commented Aug 31, 2018

While trying to do this:

Post a photo via Micropub. I post my Instagram photos to https://updates.kip.pe/ from IFTT, with a form payload like this:

h=entry&content={{Caption}}&photo={{SourceUrl}}&syndication={{Url}}&access_token=b71dfd944abbc8955fe84fc2e0229889

I encountered this error:

Before recently (I couldn't pinpoint the change that broke it), my posts would be stored as normal photo posts. I could edit them, change the picture, sync them to other sites, etc.. But after some update, they are now inlined as HTML content. And now, editing doesn't work anymore, i.e. I cannot change the photo, even if I remove the inlined one, save, and then try again. Also, my integration to sync it to Mastodon broke, because it can't deal with the inline photo. Here's how it looks in my edit UI now:

screenshot from 2018-08-24 12-59-50

Some other notes:

version = "0.9.9-a"
build = 2018082301
  • Using MySQL
  • Diagnostics page says "You are running PHP version 5.5.9-1ubuntu4.25, which cannot run Known." but everything else has been working fine. However, the editing bug might have to with a missing PHP feature? Not sure what that could be.
  • The editing issues could also be related to #2008
@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 6, 2018

I think the only recent changes to the photo endpoint was to handle multiple images.

Once I get through my backlog of emails I'll see if I can work out the breaking change...

@benwerd

This comment has been minimized.

Copy link
Member

benwerd commented Sep 6, 2018

I'm trying to take a look also. I think it's a bigger issue than just micropub, at first glance - it looks like images never link to their full source anymore.

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 6, 2018

In micropub I noticed there's a fetch by url and a post image $_FILE which are two possible routes. IIRC the former does a fetch and save (iirc), but it might be that we simplified this by using a proxied image... I'll take a look

@skddc

This comment has been minimized.

Copy link
Author

skddc commented Nov 11, 2018

Anyone had a chance to look into this yet?

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Nov 11, 2018

Just had a couple of minutes to look at it, PR waiting.

@mapkyca mapkyca closed this in 41550b5 Nov 12, 2018

@skddc

This comment has been minimized.

Copy link
Author

skddc commented Nov 14, 2018

Hooray, it works! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.