Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis is failing tests #2168

Closed
benwerd opened this Issue Sep 19, 2018 · 15 comments

Comments

Projects
None yet
2 participants
@benwerd
Copy link
Member

benwerd commented Sep 19, 2018

It looks like this is because tests are running on infrastructure that's being made obsolete? But can't say for certain yet. I'd like to work on fixing this, so we can be sure PRs are doing what they ought to.

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 19, 2018

It happens from time to time when they tweak things, plus sometimes it fails because the boot times out.

You need to look at the logs to be sure rather than relying on the check mark

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 19, 2018

Will take a look...

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 19, 2018

Yeah, on latest builds it looks like it's an individual VM not spooling up properly rather than a build error.

@mapkyca mapkyca closed this Sep 19, 2018

@benwerd benwerd reopened this Sep 19, 2018

@benwerd

This comment has been minimized.

Copy link
Member Author

benwerd commented Sep 19, 2018

It seems to always be relating to PHP 7.1. Given this, I'm inclined to move those builds into the "allowed failures" section for now.

@benwerd

This comment has been minimized.

Copy link
Member Author

benwerd commented Sep 19, 2018

(On the grounds that it's pretty important to be able to tell if a build is actually failing.)

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 19, 2018

I disagree... these seem like build errors I've seen before where a specific branch fails to spool up. This is something that unfortunately happens with travis from time to time - you always need to look at the build log rather than rely on the checkmark

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 19, 2018

E.g. current build is passing

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 19, 2018

Well, not quite, but the builds are greyed out - which admittedly I've not seen before, but points at a travis issue

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 19, 2018

(disagree on the 7.1 thing, not the knowing things are failing)

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 20, 2018

As I said previously, I'm pretty sure we can close this - the observed errors are pretty certainly temporary travis platform errors...

@benwerd

This comment has been minimized.

Copy link
Member Author

benwerd commented Sep 20, 2018

I'd rather leave it open until we're more resilient to the errors. I had a lovely evening reading Travis documentation last night, and I'm pretty sure something can be escaped to make this work.

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 20, 2018

Hmmm, I'll leave this to you, but it's intermittent (so not code), and when I've seen it (recent mongo errors not withstanding) it has been due to a timeout booting the VM. Re-running the test (e.g. by pushing a non-code commit) works

@benwerd

This comment has been minimized.

Copy link
Member Author

benwerd commented Sep 20, 2018

Yeah, It may be enough to just increase the number of retries. That's one approach I'm looking at.

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 20, 2018

There's also the other vm architecture they talk about, but when I looked that looked like a lot of work to convert and wouldn't be guaranteed to solve the problem (and would likely introduce a bunch of new ones)

@mapkyca mapkyca closed this Oct 31, 2018

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Oct 31, 2018

Seems to be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.