Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating bootstrap to version 4 #2199

Open
physcocode opened this Issue Sep 26, 2018 · 15 comments

Comments

Projects
None yet
4 participants
@physcocode
Copy link
Contributor

physcocode commented Sep 26, 2018

I was recently playing around building wild know themes and I wondered why we havnt updates to bootstrap 4 yet.

PS : if this is on the cards before 1.0 release I would be glad to make a PR

@benwerd

This comment has been minimized.

Copy link
Member

benwerd commented Sep 26, 2018

An upgrade is probably a good idea. Ideally I'd like to remove Bootstrap entirely and use CSS grids, now they're widely supported.

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 27, 2018

Bonus points if theres a 3-4 shim or something. I don't fancy changing All The Things again.

Personally, I'd like to spit front end from back end at some point, but that might be pie in the sky for v1

@physcocode

This comment has been minimized.

Copy link
Contributor Author

physcocode commented Sep 27, 2018

Its my holidays and I really want to get my hands on known core , so should I start an update to bootstrap 4 or you want me to re write in some other framework keeping BC as much as possible? Please let me know what should I start with !

@physcocode

This comment has been minimized.

Copy link
Contributor Author

physcocode commented Sep 27, 2018

Also on a personal note I would like to replace Bonita with twig or blade , keeping the front end free from PHP codes really makes the code pritty and as @mapkyca said , it will help us in keeping front and and backend really independent and clean

@physcocode

This comment has been minimized.

Copy link
Contributor Author

physcocode commented Sep 27, 2018

Please spread some light on my proposal so I can start working for a PR ASAP

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Sep 28, 2018

I'm on the fence wrt changing the templating engine. Bonita does have it's problems, but changing it would involve rewriting the world. So, ideally, if it's possible for them to co-exist and then be deprecated, that would be the way I'd like it done.

Another approach, which may be better, is to actually build the front end almost as a separate project (but often bundled), talking to the API / JSON endpoints.

@physcocode

This comment has been minimized.

Copy link
Contributor Author

physcocode commented Sep 28, 2018

Should I work on bootstrap 4 update for now ?

@benwerd

This comment has been minimized.

Copy link
Member

benwerd commented Sep 28, 2018

Bootstrap 4 makes sense for now. The other stuff (like creating a better interface separation) definitely sounds like something after 1.0.

@physcocode

This comment has been minimized.

Copy link
Contributor Author

physcocode commented Sep 28, 2018

Can we have a separate branch for bootstrap 4 were I can make pull request ? Would be much nice rather than me giving a huge pull request in main branch

@benwerd

This comment has been minimized.

Copy link
Member

benwerd commented Nov 5, 2018

I now see there's a serious known vulnerability with the version of Bootstrap we're on, so moving to 4 before any further release is a hard requirement. @physcocode, are you working on this? If not, I'll take this on as a matter of haste.

@mapkyca

This comment has been minimized.

Copy link
Member

mapkyca commented Nov 5, 2018

What's the vuln?

Also worth looking at the admin template while doing this.

@physcocode

This comment has been minimized.

Copy link
Contributor Author

physcocode commented Nov 7, 2018

@benwerd definitely up for this, whats the vuln?

@jgmac1106

This comment has been minimized.

Copy link
Contributor

jgmac1106 commented Dec 31, 2018

@benwerd @physcocode I am happy to help on the move from Bootstrap to CSS Grid.

@jgmac1106

This comment has been minimized.

Copy link
Contributor

jgmac1106 commented Jan 6, 2019

Taking a look there are plenty of Bootstrap 4->to CSS Grid style sheets these basically define a 12 grid row and use the same classes.

.or we could rethink how we name classes. Fine with either approach but wanted to see what folks think.

@physcocode

This comment has been minimized.

Copy link
Contributor Author

physcocode commented Jan 6, 2019

I was just thinking about rewriting using the new standards , also I was playing around trying to implement UI kit (just out of curiosity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.