Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Known to packagist.org #2208

Closed
mapkyca opened this Issue Sep 29, 2018 · 16 comments

Comments

Projects
3 participants
@mapkyca
Copy link
Member

commented Sep 29, 2018

We have a composer.json, which I think is all that is required.

I could do this, but it should be done via the official Known account.

@physcocode

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2018

I don't think this is everything that is required , pakagist install the package as a external component and unlike Elgg , know is still not capable of being a external package and being loaded into the project manually , correct me if I am wrong

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2018

Default "type" is "library", which expects the behaviour as you describe, but my understanding is that isn't the case if you set "type" to "project"...

@physcocode

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2018

Oops my bad , also can we install known-plugin as type : composer-plugin so that we can use composer to manage plugins depedencies too ? 🤔

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2018

You mean individual Known plugins? That would be up to the individual plugin author, but I'd probably encourage it.

@mapkyca mapkyca added this to To do in Known 1.0 via automation Oct 14, 2018

@benwerd

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

"The package name idno/Known is invalid, it should not contain uppercase characters. We suggest using idno/known instead."

@benwerd

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

Commencing breaking everything by switching the name ...

@benwerd benwerd moved this from To do to In progress in Known 1.0 Oct 25, 2018

@benwerd benwerd moved this from In progress to Needs review in Known 1.0 Oct 25, 2018

@benwerd

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

Packagist is crawling Known now. I'll close this issue once we've confirmed it's there and can be pulled.

@benwerd

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

Scratch that: a release needs to be made with the composer.json in it. So Known can't be added until a new release.

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2018

Not sure you need a release - I've added stuff without creating a github release. It does take a little while to update though...

@benwerd

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

You at least have to tag it, so people can pin to a specific version in their composer files. We'll get to that point pretty quickly. I'd really like to get 1.0 out before Thanksgiving (Nov 22).

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2018

Promises promises ;)

@physcocode

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

i wanna join the know code-a-thon

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2018

I love the sound of deadlines as they fly by ;)

From now on, lets not promise anything in terms of when 1.0 will eventually land, eh?

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Mar 2, 2019

Something to consider when doing this - might be worth looking at how the Elgg project manages its code. There, Elgg is itself installed via composer to /vendor. This seems a bit confusing, but I'm pretty sure this was done so that upgrades could be managed cleanly via composer. Also nicely segregates the core away from any custom mods built for a client.

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Just so you know, I've added projects to packagist that don't have releases. They just appear as master or dev-master, which tracks github head.

@mapkyca

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

Closing, as it is available.

You can fetch composer create-project idno/known -s dev to get the master

@mapkyca mapkyca closed this Mar 15, 2019

Known 1.0 automation moved this from Needs review to Done Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.