Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting initial plugins #2249

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
4 participants
@benwerd
Copy link
Member

commented Oct 29, 2018

Removing Firefox and taking the style / footer JS plugins out of the default stack.

@benwerd benwerd requested a review from mapkyca Oct 29, 2018

@mapkyca

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

You also removed event, was this deliberate?

Also also, might be worth looking at #2209 - which looks like to be the case, but might be worth investigating why they're reporting it's not active by default.

@benwerd benwerd merged commit 9afa599 into master Oct 30, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benwerd benwerd deleted the ben-remove-firefox-reference branch Oct 30, 2018

@benwerd

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2018

It was deliberate. Event is kind of shoddy. I'm inclined to pop it out into its own repo.

And yep. Weird that it wouldn't be on by default. Strongly suspect it's a difference between the public package and current master.

@mapkyca

This comment has been minimized.

Copy link
Member

commented Oct 30, 2018

Rather see PRs than it getting bumped tbh, things that end in their own repos tend to end up falling off people's radar... certainly my own!

@benwerd

This comment has been minimized.

Copy link
Member Author

commented Oct 30, 2018

For sure. I think I'm considering just wiping it; my take is, the fewer features to maintain, the better. Better to have a few core things that work really really well than a million that are kind of dubious.

@jgmac1106

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

+1 to smaller core and allowing community plugins though I must say Known has gotten closest to a correct event better than any platform. Still an event indo plugin would be fine

@mapkyca

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

Maybe put it up for adoption then. I don't like the idea of deleting code, and I know some people still use some of the functionality - e.g. rsvps

@mapkyca

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

Also yeah, I think event isn't terrible. I've certainly done a fair amount of work re timezones. Probably just needs a bit of spit and polish

@jgmac1106

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

@mapkyca

This comment has been minimized.

Copy link
Member

commented Oct 31, 2018

My vote would be to keep events in core, and instead knock off the rough edges. There are other plugins I'd get rid of or streamline first - e.g. comic.

I'd also be tempted to spin off footerjs etc (which has the power to break the site), with a view to replacing this with something better, as well as build #1846

@jeremycherfas

This comment has been minimized.

Copy link

commented Oct 31, 2018

+1 for leaving Events in, even if it does have rough edges. It also works, which is good even if the code isn't super smooth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.