New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Trello #11

Merged
merged 1 commit into from Jul 15, 2014

Conversation

Projects
None yet
2 participants
@eitoball
Contributor

eitoball commented Jul 13, 2014

Trello API Documetation is here.

There is no interface to add webhook on Trello, so I created page to add hook easily.

Show outdated Hide outdated lib/hooks/trello/style.css.sass
@@ -0,0 +1,12 @@
.trello-member-initials
display: block;

This comment has been minimized.

@ursm

ursm Jul 13, 2014

Member

Sass does not need the semicolon. ;)

Syntax error: Invalid CSS after "block": expected expression (e.g. 1px, bold), was ";"
        on line 2 of style.css.sass
@ursm

ursm Jul 13, 2014

Member

Sass does not need the semicolon. ;)

Syntax error: Invalid CSS after "block": expected expression (e.g. 1px, bold), was ";"
        on line 2 of style.css.sass

This comment has been minimized.

@eitoball

eitoball Jul 14, 2014

Contributor

Arg... I knew it was Sass...

Fixed and ran sass -c lib/hooks/trello/style.css.sass.

@eitoball

eitoball Jul 14, 2014

Contributor

Arg... I knew it was Sass...

Fixed and ran sass -c lib/hooks/trello/style.css.sass.

Show outdated Hide outdated lib/hooks/trello/instructions.js.hbs.hamlbars
%dd
You can add webhook URL to your board.
%p
Unfortunately there is no easy way to add webhook. You can read <a herf='https://trello.com/docs/gettingstarted/webhooks.html' target='_blank'><i class='fa fa-external-link'></i> Webhooks</a> on Trello Docs to add webhook by yourself.

This comment has been minimized.

@ursm

ursm Jul 14, 2014

Member

herf!

@ursm

ursm Jul 14, 2014

Member

herf!

This comment has been minimized.

@eitoball

eitoball Jul 14, 2014

Contributor

oh... 😮 orz...

Fixed and checked by running bundle exec haml lib/hooks/trello/instructions.js.hbs.hamlbars | tidy

@eitoball

eitoball Jul 14, 2014

Contributor

oh... 😮 orz...

Fixed and checked by running bundle exec haml lib/hooks/trello/instructions.js.hbs.hamlbars | tidy

Show outdated Hide outdated lib/hooks/trello/template_name_mapper.rb
def supports(action)
class_name = action.to_s.camelcase
begin
const_get(class_name, false)

This comment has been minimized.

@ursm

ursm Jul 14, 2014

Member

Since this code is only investigating the existence of the constant, how is it that uses not const_get but const_defined??

@ursm

ursm Jul 14, 2014

Member

Since this code is only investigating the existence of the constant, how is it that uses not const_get but const_defined??

This comment has been minimized.

@eitoball

eitoball Jul 14, 2014

Contributor

You are right. I forgot about const_defined? 😭

@eitoball

eitoball Jul 14, 2014

Contributor

You are right. I forgot about const_defined? 😭

Show outdated Hide outdated lib/hooks/trello/templates/default.html.haml
= payload.action.type
Raw body:
= raw_body

This comment has been minimized.

@ursm

ursm Jul 14, 2014

Member

Is this template still used?

@ursm

ursm Jul 14, 2014

Member

Is this template still used?

This comment has been minimized.

@eitoball

eitoball Jul 15, 2014

Contributor

Not currently. Should the file be removed? I would like to keep it for debugging purpose.

@eitoball

eitoball Jul 15, 2014

Contributor

Not currently. Should the file be removed? I would like to keep it for debugging purpose.

This comment has been minimized.

@ursm

ursm Jul 15, 2014

Member

All right, then would you rename this to debug.html.haml etc?

@ursm

ursm Jul 15, 2014

Member

All right, then would you rename this to debug.html.haml etc?

This comment has been minimized.

@eitoball

eitoball Jul 15, 2014

Contributor

Thank you. Renamed.

@eitoball

eitoball Jul 15, 2014

Contributor

Thank you. Renamed.

Show outdated Hide outdated lib/hooks/trello/template_name_mapper.rb
def supports(action)
class_name = action.to_s.camelcase
const_set(action.to_s.camelcase, Class.new(Default)) unless const_defined?(class_name, false)

This comment has been minimized.

@ursm

ursm Jul 14, 2014

Member

Will this do?

const_set(class_name, Class.new(Default)) unless ...
@ursm

ursm Jul 14, 2014

Member

Will this do?

const_set(class_name, Class.new(Default)) unless ...

This comment has been minimized.

@eitoball

eitoball Jul 15, 2014

Contributor

Yes! Thank you for catching.

@eitoball

eitoball Jul 15, 2014

Contributor

Yes! Thank you for catching.

ursm added a commit that referenced this pull request Jul 15, 2014

@ursm ursm merged commit fc2ccab into idobata:master Jul 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ursm

This comment has been minimized.

Show comment
Hide comment
@ursm

ursm Jul 15, 2014

Member

Great work. We will apply it ASAP.
Thank you! 🎱

Member

ursm commented Jul 15, 2014

Great work. We will apply it ASAP.
Thank you! 🎱

@ursm

This comment has been minimized.

Show comment
Hide comment
@ursm

ursm Jul 16, 2014

Member

Released. Many many thanks!

Member

ursm commented Jul 16, 2014

Released. Many many thanks!

@eitoball

This comment has been minimized.

Show comment
Hide comment
@eitoball

eitoball Jul 17, 2014

Contributor

🎉 Thank YOU!!!

Contributor

eitoball commented Jul 17, 2014

🎉 Thank YOU!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment