New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken change in #54 #55

Merged
merged 1 commit into from Nov 12, 2015

Conversation

Projects
None yet
2 participants
@1syo
Contributor

1syo commented Nov 12, 2015

When I send webhook, An error has occurred like this.
I fixed it.

$ IDOBATA_HOOK_URL=https://idobata.io/hook/custom/xxxxxxx foreman start
19:03:27 web.1  | started with pid 8423
19:03:28 web.1  | [2015-11-12 19:03:28] INFO  WEBrick 1.3.1
19:03:28 web.1  | [2015-11-12 19:03:28] INFO  ruby 2.2.3 (2015-08-18) [x86_64-darwin14]
19:03:28 web.1  | [2015-11-12 19:03:28] INFO  WEBrick::HTTPServer#start: pid=8423 port=5000
19:03:31 web.1  | ArgumentError - wrong number of arguments (2 for 3):
19:03:31 web.1  |   /path/to/repos/idobata-hooks/lib/idobata/hook/base.rb:76:in `initialize'
19:03:31 web.1  |   /path/to/repos/idobata-hooks/app.rb:40:in `new'
19:03:31 web.1  |   /path/to/repos/idobata-hooks/app.rb:40:in `block in <class:Application>'

hibariya added a commit that referenced this pull request Nov 12, 2015

@hibariya hibariya merged commit 39b35bc into idobata:master Nov 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hibariya

This comment has been minimized.

Show comment
Hide comment
@hibariya

hibariya Nov 12, 2015

Member

@1syo Good catch 🙏 Thank you!

Member

hibariya commented Nov 12, 2015

@1syo Good catch 🙏 Thank you!

@1syo 1syo deleted the 1syo:fix-argument_error branch Nov 12, 2015

@1syo 1syo referenced this pull request Dec 14, 2015

Merged

Spec for app #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment