New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle update #60

Merged
merged 2 commits into from Dec 7, 2015

Conversation

Projects
None yet
2 participants
@1syo
Contributor

1syo commented Dec 7, 2015

Hi,
When I ran bundle update for security alert and tried rake spec, then failed with errors like this:


  1) Idobata::Hook::Bitbucket#process_payload Pull Request POST hook pullrequest_updated event [:source]
     Failure/Error: subject { hook.process_payload }
     NoMethodError:
       undefined method `lexer' for #<Linguist::Language name=Ruby>
     # ./lib/hooks/bitbucket/helper.rb:32:in `md'
    ….

The lexer method of github-linguist has been removed from v4.3.0.
So, I recommend that we use the github-linguist v4.2.7.

What do you think?

1syo added some commits Dec 4, 2015

@hibariya

This comment has been minimized.

Show comment
Hide comment
@hibariya

hibariya Dec 7, 2015

Member

@1syo That's a good solution 🐳 Thank you for fixing the security alerts!

Member

hibariya commented Dec 7, 2015

@1syo That's a good solution 🐳 Thank you for fixing the security alerts!

hibariya added a commit that referenced this pull request Dec 7, 2015

@hibariya hibariya merged commit a0da79b into idobata:master Dec 7, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.885%
Details

@1syo 1syo deleted the 1syo:bundle-update branch Dec 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment