New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec for app #62

Merged
merged 5 commits into from Dec 15, 2015

Conversation

Projects
None yet
2 participants
@1syo
Contributor

1syo commented Dec 14, 2015

I added a test for app.rb, because I want to prevent the bug like #55

1syo added some commits Dec 14, 2015

Add rubygems for test and bundle update
vcr, webmock and rack-test
Configure RSpec
Add rubygems
Add Rack::Test::Methods
Add app_helper
I moved the setting of app_spec.rb from spec_helper.rb to app_helper.rb.
Because the tests for hook does not need them.

hibariya added a commit that referenced this pull request Dec 15, 2015

@hibariya hibariya merged commit 85554b3 into idobata:master Dec 15, 2015

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.2%) to 97.593%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hibariya

This comment has been minimized.

Show comment
Hide comment
@hibariya

hibariya Dec 15, 2015

Member

This seems convenient 😄 @1syo Thank you 🌻

Member

hibariya commented Dec 15, 2015

This seems convenient 😄 @1syo Thank you 🌻

@1syo 1syo deleted the 1syo:spec-for-app branch Dec 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment