Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Library names in package files may not contain hyphens #4292
Steps to Reproduce
The package links successfully.
I'm guessing this is a relatively trivial fix, so I'll take a look at fixing it shortly. I just wanted to document it in case I forgot about it.
Something like the following? Can't test it right now:
diff --git a/src/Idris/Parser/Helpers.hs b/src/Idris/Parser/Helpers.hs index 25a41ea7..704a6903 100644 --- a/src/Idris/Parser/Helpers.hs +++ b/src/Idris/Parser/Helpers.hs @@ -271,7 +271,7 @@ reservedIdentifiers = HS.fromList identifierOrReserved :: Parsing m => m String identifierOrReserved = token $ P.try $ do c <- P.satisfy isAlpha <|> P.oneOf "_" - cs <- P.many (P.satisfy isAlphaNum <|> P.oneOf "_'.") + cs <- P.many (P.satisfy isAlphaNum <|> P.oneOf "_'-.") return $ c : cs char :: Parsing m => Char -> m Char
Maybe a more sophisticated fix is needed so - is not allowed at end?
referenced this issue
Dec 17, 2018
The proposed fix is too wide and impacts parsing of numerical operators. I've narrowed it.
Pull request #4623