Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded zip3 and associated functions to Prelude.Vect #1635
Conversation
japesinator
added some commits
Oct 14, 2014
crufter
reviewed
Oct 14, 2014
View changes
libs/prelude/Prelude/Vect.idr
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
japesinator
Oct 14, 2014
Contributor
@Johnny-John To be honest, I thought that was a bit weird too, but I borrowed the style from zipWith and the Prelude.List zipWith3
|
@Johnny-John To be honest, I thought that was a bit weird too, but I borrowed the style from |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Melvar
Oct 14, 2014
Collaborator
It’s quite possible those were written before the comma-separated style was implemented.
|
It’s quite possible those were written before the comma-separated style was implemented. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
japesinator
Oct 14, 2014
Contributor
I think perhaps the best option is to merge this and then submit a pull request that would move from \x => \y => style to \x,y => style globally
|
I think perhaps the best option is to merge this and then submit a pull request that would move from |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
japesinator
Oct 14, 2014
Contributor
If you're curious, grep -re '\\. => \\. =>' . -I | wc -l shows that there are 18 places in the current codebase the \x => \y => style is used, and grep -re '\\.\,.' . -I | wc -l shows there are 30 places the \x,y => style is used.
|
If you're curious, |
crufter
referenced this pull request
Oct 14, 2014
Merged
Changing all lambdas to use comma separated style (e.g. '\x => \y =>' to... #1638
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I changed the lambdas to the style used in #1638 |
added a commit
that referenced
this pull request
Oct 16, 2014
edwinb
merged commit f5f4fbe
into
idris-lang:master
Oct 16, 2014
1 check passed
japesinator
deleted the
japesinator:add_zip3_vects
branch
Oct 17, 2014
pushed a commit
to msmorgan/Idris-dev
that referenced
this pull request
Aug 28, 2017
japesinator commentedOct 14, 2014
I added the
zipWith3,zip3, andunzip3functions to Prelude.Vect