Skip to content

Conversation

@t-ober
Copy link
Contributor

@t-ober t-ober commented Jun 7, 2021

Resolves #371

@t-ober t-ober added the documentation Improvements or additions to documentation label Jun 7, 2021
@t-ober t-ober added this to the Version 2.1 milestone Jun 7, 2021
@t-ober t-ober requested review from ckittl and johanneshiry June 7, 2021 07:55
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #373 (346b90f) into dev (fc5b7fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #373   +/-   ##
=========================================
  Coverage     78.56%   78.56%           
+ Complexity     2047     2046    -1     
=========================================
  Files           254      254           
  Lines          8124     8124           
  Branches        767      767           
=========================================
  Hits           6383     6383           
  Misses         1353     1353           
  Partials        388      388           
Impacted Files Coverage Δ
...e3/datamodel/models/input/connector/LineInput.java 75.86% <0.00%> (ø)
...tamodel/models/input/connector/ConnectorInput.java 53.48% <0.00%> (ø)
...model/models/input/connector/TransformerInput.java 50.00% <0.00%> (ø)
...del/models/input/connector/Transformer2WInput.java 79.48% <0.00%> (ø)
...del/models/input/connector/Transformer3WInput.java 77.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b646725...346b90f. Read the comment docs.

@johanneshiry
Copy link
Member

w/o having it reviewed yet but pls consider updating the getting started section to the latest stable version as well (bug that hasn't been fixed yet) - it is still 1.1.0 but should be 2.0.0 - thx in advance :)

@ckittl ckittl merged commit 193a1be into dev Jun 10, 2021
@ckittl ckittl deleted the to/#371-clarify-parallelDevices-param branch June 10, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ambiguous variable naming / documentation for parallelDevices of ConnectorInput

4 participants