-
Notifications
You must be signed in to change notification settings - Fork 7
ResultEntitySource interface + CsvResultEntitySource impl #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!test |
…te/PowerSystemDataModel into jh/#388-result-entity-source
src/main/java/edu/ie3/datamodel/io/source/csv/CsvDataSource.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #389 +/- ##
============================================
+ Coverage 78.56% 78.68% +0.11%
- Complexity 2046 2073 +27
============================================
Files 254 255 +1
Lines 8124 8160 +36
Branches 767 767
============================================
+ Hits 6383 6421 +38
+ Misses 1353 1352 -1
+ Partials 388 387 -1
Continue to review full report at Codecov.
|
|
@johanneshiry do you think we can approve and merge this PR? Please, take a look at the test I wrote ( |
Resolves #388