Skip to content

Add impedance weighted graph #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 20, 2022
Merged

Add impedance weighted graph #441

merged 12 commits into from
Jan 20, 2022

Conversation

@ckittl
Copy link
Member

@ckittl ckittl commented Oct 15, 2021

Resolves #440

@ckittl ckittl added the enhancement New feature or request label Oct 15, 2021
@ckittl ckittl added this to the Version 2.1 milestone Oct 15, 2021
@ckittl ckittl requested a review from a team October 15, 2021 09:58
@ckittl ckittl self-assigned this Oct 15, 2021
@ckittl
Copy link
Member Author

ckittl commented Oct 19, 2021

!test

@ckittl
Copy link
Member Author

ckittl commented Oct 19, 2021

!test

@johanneshiry johanneshiry modified the milestones: Version 2.1, Version 2.2 Jan 5, 2022
t-ober
t-ober requested changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few questions and a simplification proposal.

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #441 (8493071) into dev (89d894e) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #441      +/-   ##
============================================
+ Coverage     78.89%   78.93%   +0.04%     
- Complexity     2107     2130      +23     
============================================
  Files           263      265       +2     
  Lines          8273     8361      +88     
  Branches        780      786       +6     
============================================
+ Hits           6527     6600      +73     
- Misses         1345     1358      +13     
- Partials        401      403       +2
Impacted Files Coverage Δ
...atamodel/models/input/system/type/BmTypeInput.java 73.68% <0.00%> (-5.27%) ⬇️
...n/java/edu/ie3/datamodel/utils/ContainerUtils.java 81.42% <0.00%> (-1.05%) ⬇️
...e3/datamodel/utils/validation/ValidationUtils.java 94.17% <0.00%> (-0.83%) ⬇️
...del/utils/validation/ConnectorValidationUtils.java 87.57% <0.00%> (-0.08%) ⬇️
...del/models/input/system/type/StorageTypeInput.java 69.44% <0.00%> (ø)
...edu/ie3/datamodel/graph/ImpedanceWeightedEdge.java 50.00% <0.00%> (ø)
...du/ie3/datamodel/graph/ImpedanceWeightedGraph.java 60.00% <0.00%> (ø)
...datamodel/io/naming/DefaultDirectoryHierarchy.java 93.96% <0.00%> (+0.86%) ⬆️
...tamodel/models/input/system/type/ChpTypeInput.java 73.07% <0.00%> (+3.84%) ⬆️
.../datamodel/models/input/connector/SwitchInput.java 83.33% <0.00%> (+10.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd31239...8493071. Read the comment docs.

@ckittl ckittl requested a review from t-ober January 19, 2022 07:10
t-ober
t-ober requested changes Jan 19, 2022
View reviewed changes
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@ckittl ckittl requested a review from t-ober January 20, 2022 13:06
@sonarqubegithubprchecks
Copy link

sonarqubegithubprchecks bot commented Jan 20, 2022

Passed

Analysis Details

7 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell7 Code Smells

Coverage and Duplications

  • 60 percent coverage75.49% Coverage (78.10% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.20% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@t-ober t-ober merged commit 330e28f into dev Jan 20, 2022
@t-ober t-ober deleted the ck/#440-impedanceWeightedGraph branch January 20, 2022 15:53
@sebastian-peter sebastian-peter modified the milestones: Version 2.2, Version 3.0 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-ober t-ober t-ober approved these changes

Assignees

@ckittl ckittl

Labels

enhancement New feature or request

Projects

None yet

Milestone

Version 3.0

Development

Successfully merging this pull request may close these issues.

Add impedance weighted graph

5 participants

@ckittl @t-ober @sebastian-peter @johanneshiry