From cc760a3646cfe497dd204aa2c649dc06900674cc Mon Sep 17 00:00:00 2001 From: kkarthik11 <58599230+kkarthik11@users.noreply.github.com> Date: Thu, 13 Nov 2025 15:30:53 +0100 Subject: [PATCH 1/3] Update EvModel.java chnages with cosphi #259 --- .../java/edu/ie3/simona/api/data/model/ev/EvModel.java | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/java/edu/ie3/simona/api/data/model/ev/EvModel.java b/src/main/java/edu/ie3/simona/api/data/model/ev/EvModel.java index 04c1fd05..d112b570 100644 --- a/src/main/java/edu/ie3/simona/api/data/model/ev/EvModel.java +++ b/src/main/java/edu/ie3/simona/api/data/model/ev/EvModel.java @@ -23,15 +23,20 @@ public interface EvModel { String getId(); /** - * @return the maximum AC charging power of this ev (as active power) + * @return the maximum AC charging power of this ev */ - ComparableQuantity getPRatedAC(); + ComparableQuantity getSRatedAC(); /** * @return the maximum DC charging power of this ev (as active power) */ ComparableQuantity getPRatedDC(); + /** + * @return the power factor of this ev + */ + Double getCosPhiRated(); + /** * @return the storage capacity of this ev's battery */ From ad46618bf3db169f857fd594d5083d1d924244eb Mon Sep 17 00:00:00 2001 From: Karthik K Date: Fri, 14 Nov 2025 11:31:48 +0100 Subject: [PATCH 2/3] Resolves #259 gradle updates for the EVModel --- .../java/edu/ie3/simona/api/data/model/ev/EvModel.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/edu/ie3/simona/api/data/model/ev/EvModel.java b/src/main/java/edu/ie3/simona/api/data/model/ev/EvModel.java index d112b570..3f17aa8a 100644 --- a/src/main/java/edu/ie3/simona/api/data/model/ev/EvModel.java +++ b/src/main/java/edu/ie3/simona/api/data/model/ev/EvModel.java @@ -32,11 +32,11 @@ public interface EvModel { */ ComparableQuantity getPRatedDC(); - /** - * @return the power factor of this ev - */ + /** + * @return the power factor of this ev + */ Double getCosPhiRated(); - + /** * @return the storage capacity of this ev's battery */ From 1a388c2b153389664e129ba81fb62bd18d2abf89 Mon Sep 17 00:00:00 2001 From: kkarthik11 <58599230+kkarthik11@users.noreply.github.com> Date: Fri, 14 Nov 2025 11:39:21 +0100 Subject: [PATCH 3/3] Update CHANGELOG.md Resolves #259 updated the change log --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c751014f..46c3e4fd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Changes to sent and received em data [#2366](https://github.com/ie3-institute/simonaAPI/issues/366) +- Changed the PRated in the EvModel to SRated and added cosphi to the model [#259](https://github.com/ie3-institute/simonaAPI/issues/259) ### Fixed - Issues related to em data [#2366](https://github.com/ie3-institute/simonaAPI/issues/366)