Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested token submods should be byte-string wrapped #65

Closed
laurencelundblade opened this issue Oct 19, 2020 · 1 comment
Closed

nested token submods should be byte-string wrapped #65

laurencelundblade opened this issue Oct 19, 2020 · 1 comment

Comments

@laurencelundblade
Copy link
Collaborator

@laurencelundblade laurencelundblade commented Oct 19, 2020

Right now, the second type of submod, the embedding of a full signed EAT token inside surrounding token is "direct".

I think it needs to be wrapped in a byte string to make it reasonable to implement. When decoding the surrounding token, the nested token will be returned as a byte string that can be easily passed to the COSE/CWT/EAT decoder as these will typically take a byte string as input.

If it is not a byte string, then you have to convince the CBOR decoder to return the CWT Tag as a byte string even though it is not a byte string or the same or related instance of the CBOR decoder used to decode the outside EAT must be used to decode the inside EAT.

No semantics would change. This is only for a practical consideration of the APIs used for decoding CBOR, COSE, CWT and EAT.

@laurencelundblade
Copy link
Collaborator Author

@laurencelundblade laurencelundblade commented Nov 27, 2020

Fixed with #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant