Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-ART: Separation of architecture and interface documents #879

Closed
gorryfair opened this issue Sep 19, 2021 · 11 comments · Fixed by #938
Closed

ART-ART: Separation of architecture and interface documents #879

gorryfair opened this issue Sep 19, 2021 · 11 comments · Fixed by #938
Assignees

Comments

@gorryfair
Copy link
Contributor

@gorryfair gorryfair commented Sep 19, 2021

Early art-art review of draft-ietf-taps-architecture

My first observation and request is that the group rethink the separation of
the architecture and interface documents. It is a warning-sign that the
interface document is a normative reference for the architecture document. As
the documents are currently constructed, a new reader cannot grasp the
architecture without inferring some of it through reading the interface.

Consider reformulating the architecture document as an overview - introduce
principles, concepts, and terminology, but don't attempt to be normative.
(There are signs that this may already be, or have been, a path the document
was being pushed towards). If nothing else, rename it, and acknowledge that the
actual architecture is specified using the interface definition.

Note that the first sentence of the Overview in the interface document also
highlights the current structural problem.

@gorryfair
Copy link
Contributor Author

@gorryfair gorryfair commented Sep 19, 2021

I don't entirely agree with this ART-ART comment: I think I might well agree with moving more of the description to this Arch document, but as discussed before, I also think it useful here to set the actual requirements for the architecture, and to define the architecture. It may need to be much clearer that this architecture consists of more the API.

@mwelzl
Copy link
Contributor

@mwelzl mwelzl commented Sep 21, 2021

For completeness, this is the first statement of the interface document review:

This document reads fairly well. I have some structural concerns (see the early
review of the architecture document). In particular I think this document
contains the actual definition of the architecture and some of that is
inferential.

@britram
Copy link
Contributor

@britram britram commented Sep 22, 2021

Discussion at September 2021 interim:

  • pass through this document with a view toward making it a high level introduction, not an architecture definition: "An Introduction to the Transport Services Architecture".
  • remove normative language from this document (moving it to API, where necessary).
  • move details not useful in a high level intro to API.

@tfpauly
Copy link
Contributor

@tfpauly tfpauly commented Sep 22, 2021

I disagree with this conclusion at first pass—we did a specific analysis and pass on this over a year ago, with PR #564. The normative language and the standards-track aspect was very intentional and something the WG had consensus on. The point is that the API is a specific incarnation of the TAPS architecture, but there are overarching architectural properties that go beyond a specific abstract API.

@gorryfair
Copy link
Contributor Author

@gorryfair gorryfair commented Oct 15, 2021

I completely agree with Tommy here, and recommend we fix this in #929. We should also of course check for any stray text or missing concepts.
I think it would also be useful to somehow better explain that in figure 3 the API function is ONE part of the system.

@gorryfair gorryfair linked a pull request Oct 15, 2021 that will close this issue
@gorryfair
Copy link
Contributor Author

@gorryfair gorryfair commented Oct 15, 2021

See linked PR first please to see if this resolves this?

@tfpauly tfpauly assigned gorryfair and unassigned tfpauly Oct 19, 2021
@gorryfair gorryfair reopened this Oct 19, 2021
@gorryfair
Copy link
Contributor Author

@gorryfair gorryfair commented Oct 19, 2021

A PR was merged that addressed important text issues with separation of requirements and overview, and should more clearly set out that the requirements are for the system. The question of whether the overall TAPS systems requirements belong in this ID; the API; or a separate RFC needs some discussion based on the review, before this can be closed.

@abrunstrom
Copy link
Contributor

@abrunstrom abrunstrom commented Oct 19, 2021

Many good text improvements in the PR @gorryfair, but I noticed two smaller updates in the PR that I think were incorrect. Fixed in #940

@britram britram removed the discuss label Oct 20, 2021
@gorryfair
Copy link
Contributor Author

@gorryfair gorryfair commented Oct 20, 2021

The review comment showed were many places where the wording of architecture can be improved. There are some high level principles that I think should remain in the architecture document. The decision in today's interim is to review the architecture to get this more into a shape that is valuable as a reference, and then check the updated draft.

@gorryfair
Copy link
Contributor Author

@gorryfair gorryfair commented Nov 1, 2021

I now suggest the issues are addressed and we close this issue without moving text between documents

@mwelzl
Copy link
Contributor

@mwelzl mwelzl commented Nov 2, 2021

I agree with that; closing.

@mwelzl mwelzl closed this Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants