Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming Whitespace from the beginning of DISCUSS and COMMENT #781

Closed
ietf-svn-bot opened this issue Mar 1, 2012 · 7 comments
Closed

Trimming Whitespace from the beginning of DISCUSS and COMMENT #781

ietf-svn-bot opened this issue Mar 1, 2012 · 7 comments

Comments

@ietf-svn-bot
Copy link

ietf-svn-bot commented Mar 1, 2012

resolution_fixed type_defect | by housley@vigilsec.com


Prior to the conversion, an AD entering text in the discuss or
comment box had greater control over the formatting. The new form
seems to trim whitespace from the front of the provided text.


Issue migrated from trac:781 at 2022-03-04 01:59:39 +0000

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented Mar 1, 2012

@henrik@levkowetz.com commented


From rjsparks@nostrum.com:

I agree with a first step of getting closer to where we were.

That said, prior to conversion, the reflow mechanics, particularly when
preparing email, have been consistently in my way. Can we move to something
that performs reflow by default, but allows us to turn it off and provide
our own formatting when it's the best way to get the information across?

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented Mar 1, 2012

@henrik@levkowetz.com commented


On 2012-02-28 22:03 Robert Sparks said:

I agree with a first step of getting closer to where we were.

That said, prior to conversion, the reflow mechanics, particularly when
preparing email, have been consistently in my way. Can we move to something
that performs reflow by default, but allows us to turn it off and provide
our own formatting when it's the best way to get the information across?

That should be possible, but may move the re-flowing operation from
entry to presentation, where I believe we have it now, in order to not
mess with what's entered into the database.

Can you give me some examples of where reflowing is messing things up?

If re-flowing is only applied for very long lines and on presentation,
then anything you enter with proper formatting should be left alone.
I'll check the code to see if this is the way it's being handled now.

RjS

On 2/28/12 2:58 PM, Russ Housley wrote:

Prior to the conversion, an AD entering text in the discuss or
comment box had greater control over the formatting. The new form
seems to trim whitespace from the front of the provided text.

Ok; we should check whether this is done on entry or at presentation
time -- do you have an example to look at?

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented Mar 2, 2012

@olau@iola.dk commented


I have a fix that addresses the Russ's bug. We should probably open another one for the reformatting problem based on the discussion in

http://www.ietf.org/mail-archive/web/iola-conversion-tool/current/msg00139.html

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented Mar 2, 2012

@olau@iola.dk changed status from new to closed

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented Mar 2, 2012

@olau@iola.dk changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented Mar 2, 2012

@olau@iola.dk commented


Fixed in 7747e3a:

Only trim ballot discusses/comments on the right side, not the left, since some ADs are using the left-side for formatting, fixes #781.

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented Mar 2, 2012

@henrik@levkowetz.com changed status from closed to deployed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants