Skip to content

fix maxOccurs default value in the EBML Schema#396

Merged
robUx4 merged 2 commits intoietf-wg-cellar:masterfrom
nerg4l:fix-max-occurs-default-val
Feb 23, 2021
Merged

fix maxOccurs default value in the EBML Schema#396
robUx4 merged 2 commits intoietf-wg-cellar:masterfrom
nerg4l:fix-max-occurs-default-val

Conversation

@nerg4l
Copy link
Copy Markdown
Contributor

@nerg4l nerg4l commented Feb 8, 2021

A PR as promised.

Fixes #395

Feel free to add suggestion for the wording, or simply commit your changes on this PR (I allowed edits by maintainers).

@nerg4l nerg4l force-pushed the fix-max-occurs-default-val branch from 097ee19 to d4c63d9 Compare February 8, 2021 18:50
@robUx4 robUx4 added bug errata-rfc8794 Errors found in RFC 8794 labels Feb 14, 2021
@robUx4
Copy link
Copy Markdown
Collaborator

robUx4 commented Feb 14, 2021

I think you should split the PR in 2. While the XSD fix is likely to make it, I'm less confident that a change of text will occur.

@robUx4
Copy link
Copy Markdown
Collaborator

robUx4 commented Feb 14, 2021

The Matroska XML file still validates with the XSD change (phew).

@nerg4l
Copy link
Copy Markdown
Contributor Author

nerg4l commented Feb 14, 2021

Is it okay if I leave the change in the specification to you? In my opinion the change is needed because the following statement is now incorrect:

maxOccurs is a nonnegative integer expressing the maximum permitted number
of occurrences of this EBML Element within its Parent Element.

The rest can be kept as is. I just wanted to clarify the meaning of "unbounded".

Copy link
Copy Markdown
Collaborator

@robUx4 robUx4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robUx4
Copy link
Copy Markdown
Collaborator

robUx4 commented Feb 14, 2021

@mcr I sent an email to the mailing list so this can be handled through the proper channels
https://mailarchive.ietf.org/arch/msg/cellar/SwUeIWgHsf0ZZ8xDu6ehGT0ZcII/

@robUx4
Copy link
Copy Markdown
Collaborator

robUx4 commented Feb 14, 2021

Is it okay if I leave the change in the specification to you? In my opinion the change is needed because the following statement is now incorrect:

maxOccurs is a nonnegative integer expressing the maximum permitted number
of occurrences of this EBML Element within its Parent Element.

The rest can be kept as is. I just wanted to clarify the meaning of "unbounded".

Just create a new PR with this other patch. It might be approved but I don't know how/if it will end up in the ERRATA.

@nerg4l
Copy link
Copy Markdown
Contributor Author

nerg4l commented Feb 14, 2021

Okay, thanks for the clarification

@robUx4 robUx4 merged commit 17c5152 into ietf-wg-cellar:master Feb 23, 2021
@robUx4
Copy link
Copy Markdown
Collaborator

robUx4 commented Feb 23, 2021

Merge thanks !
Now we have to do the RFC errata.

robUx4 pushed a commit that referenced this pull request Apr 9, 2023
* fix maxOccurs default value in the EBML Schema

* revert changes in specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug errata-rfc8794 Errors found in RFC 8794

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potentially incorrect default value for maxOccurs in XSD

3 participants