-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix maxOccurs default value in the EBML Schema #396
fix maxOccurs default value in the EBML Schema #396
Conversation
097ee19
to
d4c63d9
Compare
I think you should split the PR in 2. While the XSD fix is likely to make it, I'm less confident that a change of text will occur. |
The Matroska XML file still validates with the XSD change (phew). |
Is it okay if I leave the change in the specification to you? In my opinion the change is needed because the following statement is now incorrect:
The rest can be kept as is. I just wanted to clarify the meaning of "unbounded". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mcr I sent an email to the mailing list so this can be handled through the proper channels |
Just create a new PR with this other patch. It might be approved but I don't know how/if it will end up in the ERRATA. |
Okay, thanks for the clarification |
Merge thanks ! |
* fix maxOccurs default value in the EBML Schema * revert changes in specification
A PR as promised.
Fixes #395
Feel free to add suggestion for the wording, or simply commit your changes on this PR (I allowed edits by maintainers).