Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caution note about different bit size for METADATA_BLOCK_HEADER (24) and METADATA_BLOCK_PICTURE (32) length #113

Closed
wader opened this issue Oct 20, 2021 · 0 comments · Fixed by #133

Comments

@wader
Copy link

@wader wader commented Oct 20, 2021

There are software out there that ends up writing a truncated length in METADATA_BLOCK_PICTURE. ffmpeg used to write truncated size (now it fails instead) and now also has a workaround for decoding truncated files (https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/flac_picture.c#L129).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant