Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"run-length encoded" for constant subframe might be confusing #114

Closed
wader opened this issue Oct 20, 2021 · 1 comment · Fixed by #136
Closed

"run-length encoded" for constant subframe might be confusing #114

wader opened this issue Oct 20, 2021 · 1 comment · Fixed by #136

Comments

@wader
Copy link

@wader wader commented Oct 20, 2021

Currently says "The signal is run-length encoded and added to the stream." i remember reading it thinking it might be some generic run length encoding but it's just one constant with length of the block size as i understand it?
@wader wader changed the title "run-length encoded" for constant subframe might be confusing. "run-length encoded" for constant subframe might be confusing Oct 20, 2021
@ktmf01 ktmf01 mentioned this issue Feb 18, 2022
Merged
@ktmf01 ktmf01 closed this in #136 Mar 6, 2022
ktmf01 added a commit that referenced this issue Mar 6, 2022
@ktmf01
Rewrite prediction section (#136)
cb638df 
This fixes #114. The section is rewritten to have less emphasis on the encoding aspect and to add a basic explanation of predictor use and function.
@wader
Copy link
Author

@wader wader commented Mar 8, 2022

@ktmf01 Fix for this one and the other issues i reported look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite prediction section ktmf01/flac-specification
1 participant
@wader