Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing specification of bits-per-sample adjustment for subframes #83

Closed
fweimer opened this issue Sep 12, 2020 · 4 comments
Closed

Missing specification of bits-per-sample adjustment for subframes #83

fweimer opened this issue Sep 12, 2020 · 4 comments

Comments

@fweimer
Copy link
Contributor

fweimer commented Sep 12, 2020

The reference implementation increases the number of bits per sample by one in the following cases:

  • For the first subframe if the channel assignment is 0b1001.
  • For the second subframe if the channel assignment is 0b1000 or 0b1010.

Not doing this results in an implementation which is not interoperable.
@fweimer
Copy link
Contributor Author

fweimer commented Sep 13, 2020

Additionally, the number of bits per samples is decreased by the wasted-bits-per-sample amount.

@fweimer fweimer mentioned this issue Sep 20, 2020
Closed
@ktmf01 ktmf01 mentioned this issue Oct 2, 2021
Merged
@wader
Copy link

wader commented Oct 20, 2021

Is this same as #111 ?

@fweimer
Copy link
Contributor Author

fweimer commented Oct 22, 2021

Yes, and #98 mostly fixes it (although the bits per sample adjustment is somewhat hidden in that section).

@ktmf01
Copy link
Collaborator

ktmf01 commented Jan 25, 2022

This is fixed by #98 and will be further stressed if #120 is merged

@ktmf01 ktmf01 closed this as completed Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wader @fweimer @ktmf01