New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPC decoding details missing #88
Comments
|
@fweimer, I was reviewing whether all points you mention are included in the current PRs, and I think they are all accounted for. The negative shift is explicitly forbidden in #97, where to apply the shift is also in #97, the 32-bit math is explained in #124 and the explicit formula is in the (informative appendix) #120 The only thing I'm not sure of is the infinite precision. What do you mean by that? |
|
With infinite precision I meant that the decoder has to make sure that the linear predictor computations do not overflow by choosing a sufficiently large data type. It was not clear to me whether there was a rule that encoders had to make sure to stay within a specific numerical range (depending on sample width etc.). #124 makes it clear that decoders have to assume the worst case (what I called infinite precision). So I think everything I raised here is being addressed. Thanks! |
|
Indeed, decoders should assume the worst case. |
I think some of the LPC decoding details should be included in the specification:
SUBFRAME_LPCis negative? I don't think the reference implementation performs a left shift in this case.It may make sense to include an explicit formula for LPC decoding, so that the it's clear whether there is a minus sign involved or not.
The text was updated successfully, but these errors were encountered: