Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing singedness indication #90

Closed
fweimer opened this issue Sep 20, 2020 · 1 comment
Closed

Missing singedness indication #90

fweimer opened this issue Sep 20, 2020 · 1 comment

Comments

@fweimer
Copy link
Contributor

@fweimer fweimer commented Sep 20, 2020

In the following places of the specification, signed values are used implicitly (the default are signed values):

  • The constant value in SUBFRAME_CONSTANT.
  • The warm-up samples in SUBFRAME_FIXED.
  • The warm-up samples in SUBFRAME_LPC.
  • The sample data in SUBFRAME_VERBATIM.
  • The Golomb encoding (see this comment).

Except for the last item, these values are encoded as two's complement.
@ktmf01 ktmf01 mentioned this issue Oct 2, 2021
Merged
@ktmf01
Copy link
Collaborator

@ktmf01 ktmf01 commented Jan 28, 2022

I believe #97 and #122 fix these 5 points

@ktmf01 ktmf01 closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fweimer @ktmf01