Incorrect subframe for decoding left subframe #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decoding the left subframe in a Right-Side encoded frame, the left subframe is decoded by adding the side subframe to the right subframe, not the left subframe (the one to decode).
ktmf01
reviewed
Dec 27, 2021
Thanks a lot for pointing out this mistake of mine. I just spotted one more, maybe you can add it to this PR
|
Good catches, @MulattoKid @ktmf01, thank you! |
The Mid channel should be shifted right (divided by two), not left (multiplied by two).
|
Added @ktmf01 's find. |
retokromer
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When decoding the left subframe in a Right-Side encoded frame, the left subframe is decoded by adding the side subframe to the right subframe, not the left subframe (the one to decode).