Add a thorough explanation on all four subframe types #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retokromer
approved these changes
Oct 11, 2021
JeromeMartinez
reviewed
Oct 18, 2021
I don't know enough there for a full review, but I am not against merging this PR as is, and I'll see after most PR are merged how it is when I implement a FLAC parser based on only the spec.
The table under subframe fixed is cleaned up in source code (no difference in markdown result) and a few line breaks directly under that table that went missing were restored, so the bullet points now render correctly
retokromer
reviewed
Oct 22, 2021
retokromer
approved these changes
Oct 22, 2021
retokromer
approved these changes
Oct 28, 2021
These remarks are better placed in a separate section on numerical considerations, as this description is already too long and probably confusing
|
I'm also reopening this pull request, but I've removed quite a bit of text on data type size requirements. This was quite complicated, probably confusing and not thorough enough. I am preparing a PR on a section 'numerical considerations' in which these removed parts will return. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Please provide feedback.
This should address issues #89, #88 and most of #90