New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean segment linking explanations #541
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubblec4
reviewed
Aug 25, 2021
hubblec4
reviewed
Aug 25, 2021
hubblec4
reviewed
Aug 25, 2021
hubblec4
reviewed
Aug 25, 2021
The restriction on tracks and timescale only apply to hard linking (segment splitting). The placement of linked segments is not a hard requirement, it's up to the player or system to make sure the segments are accessible for linking.
…imestampscale rule And clarify it.
It contradicts with the rules explained after.
… invalid Plus some format cleaning
It's usually a good idea to mark linked segments with a SegmentFamily. It's not specific to ordered chapters or chapter codecs.
Soft Linking is not actually a segment linking, it doesn't represent a virtual segment to play from. It's just a way for chapter codecs to jump to other segments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #490