add a section for nested chapters rules #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
enhancement
clarifications
spec_main
hubblec4
reviewed
Aug 25, 2021
hubblec4
reviewed
Aug 25, 2021
hubblec4
reviewed
Aug 25, 2021
robUx4
force-pushed
the
nested-chapters
branch
3 times, most recently
from
090697e
to
cace8dc
Compare
There is no boolean in EBML/Matroska, the values are either 0 or 1
robUx4
force-pushed
the
nested-chapters
branch
from
cace8dc
to
9b9039d
Compare
|
Fixed some typo/grammar and added example of why nested chapters may be needed (sub tags or sub commands). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clean the ChapterFlagHidden table, there's no true/false in Matroska.
Fixes #232 by making explicit the rules that were found in DvdMenuXtractor and VLC and explaining why some usage are not possible.