make ChapterTimeEnd not mandatory on parent chapters in ordered editions #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to forbid the value if we know it.
It's not possible to set it properly.
It MUST be set on the lowest nested chapters and SHOULD NOT be set in parent chapters.
robUx4
force-pushed
the
chaptertimeend-mandatory
branch
from
57bdd06
to
95afda0
Compare
robUx4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the example in de5e15a it's clear that when it's set on a Parent Chapter it cannot be used for playback. Even when parts are contiguous.
Remove the example that was there to illustrate the old rule. Simple rules tell the whole story without going through each case.
This is still compatible with how DvdMenuXtractor generates chapter timestamps.