Skip to content

Commit

Permalink
Use GET rather than POST when polling collection jobs.
Browse files Browse the repository at this point in the history
This was first attempted as part of
571988c, since the original reason for
using POST was removeed; but the switch to GET was reverted to avoid
including (too many?) breaking wire changes.

Now that we are applying feedback from the HTTP directorate, we'll have
a number of similar breaking changes in the next DAP draft. I think this
is a good time to include this change.
  • Loading branch information
branlwyd committed Jan 22, 2024
1 parent 3aee3f8 commit cc7e5f4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions draft-ietf-ppm-dap.md
Original file line number Diff line number Diff line change
Expand Up @@ -1988,7 +1988,7 @@ Changing a collection job's parameters is illegal, so further requests to
with an HTTP client error status code.

After receiving the response to its `CollectionReq`, the Collector makes an HTTP
POST request to the collection job URI to check on the status of the collect job
GET request to the collection job URI to check on the status of the collect job
and eventually obtain the result. If the collection job is not finished yet, the
Leader responds with HTTP status 202 Accepted. The response MAY include a
Retry-After header field to suggest a polling interval to the Collector.
Expand All @@ -2007,7 +2007,7 @@ between aggregation and collection jobs that can yield trivial batch mismatch
errors.

Once both aggregate shares are successfully obtained, the Leader responds to
subsequent HTTP POST requests to the collection job with HTTP status code 200 OK
subsequent HTTP GET requests to the collection job with HTTP status code 200 OK
and a body consisting of a `Collection`:

~~~
Expand Down Expand Up @@ -2044,7 +2044,7 @@ structure includes the following:
Collector.

If obtaining aggregate shares fails, then the Leader responds to subsequent HTTP
POST requests to the collection job with an HTTP error status and a problem
GET requests to the collection job with an HTTP error status and a problem
document as described in {{errors}}.

The Leader MAY respond with HTTP status 204 No Content to requests to a
Expand Down Expand Up @@ -2254,7 +2254,7 @@ AggregateShareReq, it must first check that the job or request does not violate
the parameters associated with the DAP task. It does so as described here. Where
we say that an Aggregator MUST abort with some error, then:

- Leaders should respond to subsequent HTTP POST requests to the collection job
- Leaders should respond to subsequent HTTP GET requests to the collection job
with the indicated error.
- Helpers should respond to the AggregateShareReq with the indicated error.

Expand Down

0 comments on commit cc7e5f4

Please sign in to comment.