Add a working ec2-group-revoke. #1

Merged
merged 1 commit into from Aug 29, 2012

Conversation

Projects
None yet
2 participants
@plathrop
Contributor

plathrop commented Aug 29, 2012

No description provided.

@plathrop

This comment has been minimized.

Show comment Hide comment
@plathrop

plathrop Aug 29, 2012

Contributor

In using this I think the first think I'd change is to have it remove the line if/when the revoke operation returns successfully. As it is, there's basically no feedback.

Contributor

plathrop commented Aug 29, 2012

In using this I think the first think I'd change is to have it remove the line if/when the revoke operation returns successfully. As it is, there's basically no feedback.

@plathrop

This comment has been minimized.

Show comment Hide comment
@plathrop

plathrop Aug 29, 2012

Contributor

For the record, this is what it looks like using list operations instead of backquote:

      (apply 'ec2-call-process
             (append
              (append (list "ec2-revoke"
                            "-P" protocol
                            range-arg (concat (cdr (assoc 'low-port line))
                                              range-sep
                                              (cdr (assoc 'high-port line))))
                      source)
              (list (cdr (assoc 'name group)))))
Contributor

plathrop commented Aug 29, 2012

For the record, this is what it looks like using list operations instead of backquote:

      (apply 'ec2-call-process
             (append
              (append (list "ec2-revoke"
                            "-P" protocol
                            range-arg (concat (cdr (assoc 'low-port line))
                                              range-sep
                                              (cdr (assoc 'high-port line))))
                      source)
              (list (cdr (assoc 'name group)))))

ieure added a commit that referenced this pull request Aug 29, 2012

Merge pull request #1 from plathrop/master
Add a working ec2-group-revoke.

@ieure ieure merged commit 10bd60f into ieure:master Aug 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment