New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move most_focus method in application_controller.rb into its own helper #1011

Open
julianguyen opened this Issue Sep 26, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@julianguyen
Member

julianguyen commented Sep 26, 2018

Description

Move most_focus method in application_controller.rb into its own helper. The motivation is to declutter application_controller and have better separation of concerns. Be sure to move the tests too.

Move top_three_focus and profile_exists? in this new helper too and make them private

Do you want to be the assignee to work on this?

🚫

@julianguyen julianguyen changed the title from Move most_focus method in application_controller.rb into it's own helper to Move most_focus method in application_controller.rb into its own helper Sep 26, 2018

@sjakobi

This comment has been minimized.

Show comment
Hide comment
@sjakobi

sjakobi Sep 30, 2018

Do you want to be the assignee to work on this?

I'd like to fix this! :)

sjakobi commented Sep 30, 2018

Do you want to be the assignee to work on this?

I'd like to fix this! :)

@julianguyen

This comment has been minimized.

Show comment
Hide comment
@julianguyen

julianguyen Sep 30, 2018

Member

Hey @sjakobi, thanks for expressing your interest. We would love your help with this issue. Please check out https://github.com/ifmeorg/ifme/wiki/Join-Our-Slack for next steps :)

Member

julianguyen commented Sep 30, 2018

Hey @sjakobi, thanks for expressing your interest. We would love your help with this issue. Please check out https://github.com/ifmeorg/ifme/wiki/Join-Our-Slack for next steps :)

@jash-kothari

This comment has been minimized.

Show comment
Hide comment
@jash-kothari

jash-kothari Oct 3, 2018

If this is not being worked on would like to work on this.

jash-kothari commented Oct 3, 2018

If this is not being worked on would like to work on this.

@julianguyen

This comment has been minimized.

Show comment
Hide comment
@julianguyen

julianguyen Oct 3, 2018

Member

@jash-kothari Please follow next steps mentioned above and then assign yourself to this issue.

Member

julianguyen commented Oct 3, 2018

@jash-kothari Please follow next steps mentioned above and then assign yourself to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment