New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Profile Modal #786

Closed
nshki opened this Issue Jan 9, 2018 · 10 comments

Comments

8 participants
@nshki
Copy link
Member

nshki commented Jan 9, 2018

Overview

We are looking for an awesome human to build this out as a React component, preferably within Storybook. You can view and get details (colors, dimensions, export SVGs, etc.) by visiting the Figma designs and creating a free account.

This is part of the app redesign (#691).

Screenshot from the Figma document:

screenshot 2018-01-09 at 6 29 59 pm

@nshki nshki added the design label Jan 9, 2018

@nshki nshki added this to TODO in UX/UI Enhancements via automation Jan 9, 2018

@f3mshep

This comment has been minimized.

Copy link

f3mshep commented Feb 14, 2018

I would like to take this issue!

@nshki

This comment has been minimized.

Copy link
Member

nshki commented Feb 14, 2018

All you @f3mshep! :D

@HeyStevenXu

This comment has been minimized.

Copy link
Contributor

HeyStevenXu commented Mar 17, 2018

Hey @f3mshep , just wanted to ask if you were still working on this component! I can work on this if you've been busy- just let me know :)

@DomitriusAnthony

This comment has been minimized.

Copy link

DomitriusAnthony commented Apr 6, 2018

Would love to help!

@LachlanRidley

This comment has been minimized.

Copy link
Collaborator

LachlanRidley commented May 23, 2018

Hi @nshki, I'm having a go at making this component and I was just wondering at what stage I should make a pull request? Is it better to do it early so that I can get feedback or should I wait until it's done to my satisfaction? Thanks :)

@nshki

This comment has been minimized.

Copy link
Member

nshki commented May 23, 2018

@LachlanRidley Feel free to submit a pull request whenever you'd like! I generally only review PRs when the author(s) feels that it's done though. :)

@LachlanRidley

This comment has been minimized.

Copy link
Collaborator

LachlanRidley commented May 23, 2018

Perfect, thanks :)

@baohouse

This comment has been minimized.

Copy link
Collaborator

baohouse commented May 23, 2018

@LachlanRidley Since @julianguyen (the only admin) is away from the project at the moment, I can't assign this issue to you. So the best way to indicate that you're working on this is to submit a PR, but with a [WIP] prefix in the title line, and referencing this issue number in the description of your PR.

@LachlanRidley

This comment has been minimized.

Copy link
Collaborator

LachlanRidley commented May 24, 2018

@baohouse, thanks, I've done that

@LachlanRidley LachlanRidley self-assigned this May 24, 2018

@aSquare14 aSquare14 added this to To-Do ReactJs in RSGOC 2018: Team Rubies Jul 2, 2018

@aSquare14

This comment has been minimized.

Copy link
Member

aSquare14 commented Jul 4, 2018

I'm taking this up ! :D

@LachlanRidley LachlanRidley removed their assignment Jul 10, 2018

@aSquare14 aSquare14 self-assigned this Jul 10, 2018

@julianguyen julianguyen removed this from To-Do ReactJs in RSGOC 2018: Team Rubies Aug 3, 2018

UX/UI Enhancements automation moved this from TODO to Completed Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment