New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full screen modal bug in mobile web #991

Open
julianguyen opened this Issue Sep 22, 2018 · 12 comments

Comments

Projects
None yet
4 participants
@julianguyen
Member

julianguyen commented Sep 22, 2018

Description

In mobile Chrome, there's a bug with our modal where the address bar is blocking the top part of the modal. Let's fix this!

This post may give you some insights on how to fix it.

Reproduction Steps

  1. Open mobile Chrome
  2. Open any modal (Notifications for example)

Screenshots

image

Do you want to be the assignee to work on this?

🚫

@mialahmoka

This comment has been minimized.

Show comment
Hide comment
@mialahmoka

mialahmoka Sep 22, 2018

Member

I'd like to work on this

Member

mialahmoka commented Sep 22, 2018

I'd like to work on this

@julianguyen

This comment has been minimized.

Show comment
Hide comment
@julianguyen

julianguyen Sep 22, 2018

Member

Hi @mialahmoka :) Thanks for expressing your interest, we would love for your help. Here are next steps for contributing: https://github.com/ifmeorg/ifme/wiki/Join-Our-Slack

Member

julianguyen commented Sep 22, 2018

Hi @mialahmoka :) Thanks for expressing your interest, we would love for your help. Here are next steps for contributing: https://github.com/ifmeorg/ifme/wiki/Join-Our-Slack

@vishalsodani

This comment has been minimized.

Show comment
Hide comment
@vishalsodani

vishalsodani Oct 6, 2018

@julianguyen I want to work on this. Do I have to join slack and then self-assign?

vishalsodani commented Oct 6, 2018

@julianguyen I want to work on this. Do I have to join slack and then self-assign?

@member-cop

This comment has been minimized.

Show comment
Hide comment
@member-cop

member-cop bot Oct 6, 2018

Hey @vishalsodani, thanks for expressing your interest. We would love your help with this issue. Please follow these next steps to join our contributor community.

member-cop bot commented Oct 6, 2018

Hey @vishalsodani, thanks for expressing your interest. We would love your help with this issue. Please follow these next steps to join our contributor community.

@julianguyen

This comment has been minimized.

Show comment
Hide comment
@julianguyen

julianguyen Oct 8, 2018

Member

@vishalsodani Yep, once you contact us and we add you to our GitHub org, you can self-assign.

Member

julianguyen commented Oct 8, 2018

@vishalsodani Yep, once you contact us and we add you to our GitHub org, you can self-assign.

@lsurasani

This comment has been minimized.

Show comment
Hide comment
@lsurasani

lsurasani Oct 11, 2018

Hey! Unsure if @vishalsodani is working on it but I'd like to take a look if not!

lsurasani commented Oct 11, 2018

Hey! Unsure if @vishalsodani is working on it but I'd like to take a look if not!

@member-cop

This comment has been minimized.

Show comment
Hide comment
@member-cop

member-cop bot Oct 11, 2018

Hey @lsurasani, thanks for expressing your interest. We would love your help with this issue. Please follow these next steps to join our contributor community.

member-cop bot commented Oct 11, 2018

Hey @lsurasani, thanks for expressing your interest. We would love your help with this issue. Please follow these next steps to join our contributor community.

@vishalsodani

This comment has been minimized.

Show comment
Hide comment
@vishalsodani

vishalsodani Oct 11, 2018

Hey! Unsure if @vishalsodani is working on it but I'd like to take a look if not!
@lsurasani
Please go ahead. I am not taking up this issue.

vishalsodani commented Oct 11, 2018

Hey! Unsure if @vishalsodani is working on it but I'd like to take a look if not!
@lsurasani
Please go ahead. I am not taking up this issue.

@member-cop

This comment has been minimized.

Show comment
Hide comment
@member-cop

member-cop bot Oct 11, 2018

Hey @vishalsodani, thanks for expressing your interest. We would love your help with this issue. Please follow these next steps to join our contributor community.

member-cop bot commented Oct 11, 2018

Hey @vishalsodani, thanks for expressing your interest. We would love your help with this issue. Please follow these next steps to join our contributor community.

@lsurasani lsurasani assigned lsurasani and unassigned lsurasani Oct 11, 2018

@lsurasani

This comment has been minimized.

Show comment
Hide comment
@lsurasani

lsurasani Oct 16, 2018

my android emulator is having trouble properly displaying localhost so I'm going to unassign myself from this

lsurasani commented Oct 16, 2018

my android emulator is having trouble properly displaying localhost so I'm going to unassign myself from this

@julianguyen

This comment has been minimized.

Show comment
Hide comment
@julianguyen

julianguyen Oct 16, 2018

Member

@lsurasani Oh no sorry to hear. Did you try remote debugging via Chrome by any chance?

Member

julianguyen commented Oct 16, 2018

@lsurasani Oh no sorry to hear. Did you try remote debugging via Chrome by any chance?

@lsurasani

This comment has been minimized.

Show comment
Hide comment
@lsurasani

lsurasani Oct 16, 2018

@julianguyen I did! But it wasn't giving me any errors -- for whatever reason the stylesheets/css just weren't loading

lsurasani commented Oct 16, 2018

@julianguyen I did! But it wasn't giving me any errors -- for whatever reason the stylesheets/css just weren't loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment