Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Switch component added #910
Overall this looks great, thanks a bunch for working on this! :)
I left a few minor comments. Would love to see what @julianguyen thinks as well. We may need a way to provide a name attribute to the hidden input in this component for forms.
Thanks for adding test coverage!
Left some comments, let me know if you have any questions.
Looking great so far :)
Not a problem . All the best !…
On Sat, Oct 6, 2018, 7:07 PM Julia Nguyen ***@***.***> wrote: I'm going to finish up this feature. I'm sorry we didn't get a chance to wrap this up for RGSoC. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#910 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV4EVSROOqZxVyIYNlJVavTELHd8m9YNks5uiLIqgaJpZM4VAkmA> .