Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ui::ws::StackAtTop impl #107

Closed
tonikitoo opened this issue Jun 5, 2017 · 1 comment
Closed

fix ui::ws::StackAtTop impl #107

tonikitoo opened this issue Jun 5, 2017 · 1 comment

Comments

@tonikitoo
Copy link
Member

Currently, we simple bail out early, unconditionally.
@tonikitoo
Copy link
Member Author

This was fixed by ef993dc

msisov pushed a commit to msisov/chromium that referenced this issue Sep 25, 2017
Incrementing VERSION to 62.0.3202.14
72cd8e7 
TBR=dimu@chromium.org

Change-Id: I2fdb970a67f95de62db20da00b1c9c919f66c9bb
Reviewed-on: https://chromium-review.googlesource.com/658500
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{Igalia#107}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
msisov pushed a commit that referenced this issue Dec 23, 2018
@darrnshn
[Merge M71] Reland "[VK] Hide the virtual keyboard when we enter wind…
5c7ff63 
…ow overview mode."

This is a reland of a643a13

Changed it to use HideKeyboardByUser instead of
HideKeyboardImplicitlyBySystem as we do not want to reshow the VK
if there's focus (see description of HideKeyboardImplicitlyBySystem).

A "proper" fix is to actually allow clients to specify whether an input
field should bring up the VK (like inputmode="none" in HTML). Then we
can just remove this special case code.

TBR=jamescook@chromium.org, xdai@chromium.org

Original change's description:
> [VK] Hide the virtual keyboard when we enter window overview mode.
>
> When we enter window overview mode (e.g. by dragging the top of an app),
> we need to hide the virtual keyboard because:
>
> 1) It blocks the overview mode UI for no reason.
> 2) The previews of windows have blank space at the bottom because that's
>    where the keyboard is.
>
> Bug: 893856
> Change-Id: I4f79f6bf603fd074a62b7ba29366ec5af18bbab2
> Reviewed-on: https://chromium-review.googlesource.com/c/1278565
> Commit-Queue: Darren Shen <shend@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599561}

Bug: 893856
Change-Id: Ibe9a1873cda3972520c75338db1b108d6274e005
Reviewed-on: https://chromium-review.googlesource.com/c/1280098
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599603}(cherry picked from commit 8bc834f)
Reviewed-on: https://chromium-review.googlesource.com/c/1287329
Cr-Commit-Position: refs/branch-heads/3578@{#107}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
msisov pushed a commit that referenced this issue Jan 31, 2019
UMA stats for WebRTC text logging.
3b01859 
Adds stats for start, discard, upload started, upload succeeded, and upload failed.

Bug: 809903
Change-Id: I330cff6f975ddfa93a189d3de131627cb7249155
Reviewed-on: https://chromium-review.googlesource.com/c/1354446
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613912}(cherry picked from commit e94a2eb)
Reviewed-on: https://chromium-review.googlesource.com/c/1365243
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#107}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
msisov pushed a commit that referenced this issue Mar 14, 2019
This is the cherry pick merge for the M73 branch which was approved h…
e49f31f 
…ere: http://crbug.com/926896

[Autofill Assistant] Add a histogram for drop outs.

This patch introduces a histogram to track how AA is closed or fails.
It only includes the drop out part with an initial generic "Autostart"
event for "no drop out". Another histogram for different flavors to start
AA will follow. Some of these bucket names will be refined later.

Bug: 806868
Change-Id: If97a7dde70e2be61424838c426cf076a0241e885
Reviewed-on: https://chromium-review.googlesource.com/c/1425614
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626536}(cherry picked from commit 217b627)
Reviewed-on: https://chromium-review.googlesource.com/c/1448234
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#107}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tonikitoo