New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix or update tests for remaining php 8.0 failures on nightly builds #278
Comments
Is this what is causing my compile failures in https://git.mtech-llc.com/open-source/drupal-docker/-/jobs/5770#L708 |
@heddn it looks separate API change |
That looks like an issue in phpredis at a glance. Also, I haven't checked, but you want the master branch of igbinary - the php8 compatibility fixes for the latest commits to php 8.0 aren't in a pecl release yet. |
Same for php redis - it needs to use master phpredis/phpredis@a7662da |
I'm using the develop branch now for redis. I'll see about doing the same for igbinary as well. Thanks. |
It seems like the issue @heddn reported was (potentially) fixed in phpredis/phpredis@a7662da |
These all seem harmless, and the only thing that changed was the var_dump output for cyclic reference arrays after unserialization (and possibly before, unrelated to igbinary) |
Yes, this tests probably needs split for 8.x |
I was planning on that if that was only a change in the representation emitted by var_dump (or handling of cyclic arrays when passed to functions by php) |
e.g. add a different test if the rendering of cyclic values is slightly different in php 8.0
The text was updated successfully, but these errors were encountered: