Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or update tests for remaining php 8.0 failures on nightly builds #278

Closed
TysonAndre opened this issue Jul 11, 2020 · 9 comments · Fixed by #283
Closed

Fix or update tests for remaining php 8.0 failures on nightly builds #278

TysonAndre opened this issue Jul 11, 2020 · 9 comments · Fixed by #283

Comments

@TysonAndre
Copy link
Member

e.g. add a different test if the rendering of cyclic values is slightly different in php 8.0

@heddn
Copy link

heddn commented Jul 13, 2020

Is this what is causing my compile failures in https://git.mtech-llc.com/open-source/drupal-docker/-/jobs/5770#L708

@andypost
Copy link

@heddn it looks separate API change

@TysonAndre
Copy link
Member Author

That looks like an issue in phpredis at a glance. Also, I haven't checked, but you want the master branch of igbinary - the php8 compatibility fixes for the latest commits to php 8.0 aren't in a pecl release yet.

@andypost
Copy link

Same for php redis - it needs to use master phpredis/phpredis@a7662da

@heddn
Copy link

heddn commented Jul 13, 2020

I'm using the develop branch now for redis. I'll see about doing the same for igbinary as well. Thanks.

@TysonAndre
Copy link
Member Author

TysonAndre commented Jul 13, 2020

It seems like the issue @heddn reported was (potentially) fixed in phpredis/phpredis@a7662da

@TysonAndre
Copy link
Member Author

Check for reference serialization (Original example, not using var_dump) [tests/igbinary_009b.phpt]
Cyclic array test [tests/igbinary_026.phpt]
Cyclic array test 2 [tests/igbinary_026b.phpt]

These all seem harmless, and the only thing that changed was the var_dump output for cyclic reference arrays after unserialization (and possibly before, unrelated to igbinary)

@andypost
Copy link

andypost commented Aug 5, 2020

Yes, this tests probably needs split for 8.x

@TysonAndre
Copy link
Member Author

Yes, this tests probably needs split for 8.x

I was planning on that if that was only a change in the representation emitted by var_dump (or handling of cyclic arrays when passed to functions by php)

TysonAndre added a commit to TysonAndre/igbinary that referenced this issue Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants