Fixes #51: Improve "unsupported version" message in unserialization #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
force-pushed
the
unsupported_version-warning-reword
branch
from
88ee8fa
to
e302c09
Compare
Closed
(When unserializing the 4-byte binary header) 1. If all of the characters are printable ASCII, then print a different error message as a warning (Print the string representation instead of the little endian representation). This makes it more obvious if JSON, php, etc. serialization formats are incorrectly passed in. 2. If there are 1-4 bytes in the string, there previously wasn't a php warning, but this failed and returned null. Emit a warning. (This continues to emit no warnings when false or the empty string are passed in) 3. Add comment to warning if version appears to have incorrect endianness (i.e. 0th byte set instead of 3rd byte)
TysonAndre
force-pushed
the
unsupported_version-warning-reword
branch
from
e302c09
to
d59af13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
then print a different error
message as a warning (Print the string representation instead of the
little endian representation).
This makes it more obvious if JSON, php, etc. serialization
formats are incorrectly passed in.
This adds appropriate backslashes.
there previously wasn't a php warning, but this returned false.
Emit one. (The smallest total serialized data length is (4+1) for things such as igbinary_serialize(null): "\x00\x00\x00\x02\x00")
(This continues to not emit a warning for false or the empty string)