Fixed a couple of goroutine leaks. #1

Merged
merged 3 commits into from Mar 13, 2013

Conversation

Projects
None yet
2 participants
Contributor

dustin commented Mar 13, 2013

Hi, we've been using this in cbugg and I found and fixed a couple goroutine leaks.

dustin added some commits Mar 8, 2013

@dustin dustin Don't hang forever on message writes. 4321528
@dustin dustin Buffer the output channel.
Considering before it was effectively infinitely buffering it with
goroutines, having a small explicit (and bounded) buffer would
semantically similar.
96a6ff6
@dustin dustin Don't hang forever when a connection is closed. 5c834d5

igm was assigned Mar 13, 2013

@igm igm added a commit that referenced this pull request Mar 13, 2013

@igm igm Merge pull request #1 from couchbaselabs/master
Fixed a couple of goroutine leaks.
a6a65a8

@igm igm merged commit a6a65a8 into igm:master Mar 13, 2013

Owner

igm commented Mar 13, 2013

thanks!

@aristofanio aristofanio added a commit to ag-ifpb/sockjs-go that referenced this pull request Sep 18, 2016

@aristofanio aristofanio structuring for heroku/vendor #1 8666b0d

@aristofanio aristofanio added a commit to ag-ifpb/sockjs-go that referenced this pull request Sep 18, 2016

@aristofanio aristofanio saving #1 5abb971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment