From a1e623590bce424d9246634d547dee221182858c Mon Sep 17 00:00:00 2001 From: ltacker Date: Wed, 10 Mar 2021 15:46:37 +0100 Subject: [PATCH 1/6] Refactor host --- starport/chainconf/config.go | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/starport/chainconf/config.go b/starport/chainconf/config.go index a9c5b5f068..8cb011bb60 100644 --- a/starport/chainconf/config.go +++ b/starport/chainconf/config.go @@ -20,14 +20,14 @@ var ( // DefaultConf holds default configuration. DefaultConf = Config{ - Servers: Servers{ - RPCAddr: "0.0.0.0:26657", - P2PAddr: "0.0.0.0:26656", - ProfAddr: "0.0.0.0:6060", - GRPCAddr: "0.0.0.0:9090", - APIAddr: "0.0.0.0:1317", - FrontendAddr: "0.0.0.0:8080", - DevUIAddr: "0.0.0.0:12345", + Host: Host{ + RPC: ":26657", + P2P: ":26656", + Prof: ":6060", + GRPC: ":9090", + API: ":1317", + Frontend: ":8080", + DevUI: ":12345", }, Build: Build{ Proto: Proto{ @@ -53,7 +53,7 @@ type Config struct { Build Build `yaml:"build"` Init Init `yaml:"init"` Genesis map[string]interface{} `yaml:"genesis"` - Servers Servers `yaml:"servers"` + Host Host `yaml:"host"` } // AccountByName finds account by name. @@ -133,15 +133,15 @@ type Init struct { KeyringBackend string `yaml:"keyring-backend"` } -// Servers keeps configuration related to started servers. -type Servers struct { - RPCAddr string `yaml:"rpc-address"` - P2PAddr string `yaml:"p2p-address"` - ProfAddr string `yaml:"prof-address"` - GRPCAddr string `yaml:"grpc-address"` - APIAddr string `yaml:"api-address"` - FrontendAddr string `yaml:"frontend-address"` - DevUIAddr string `yaml:"dev-ui-address"` +// Host keeps configuration related to started servers. +type Host struct { + RPC string `yaml:"rpc"` + P2P string `yaml:"p2p"` + Prof string `yaml:"prof"` + GRPC string `yaml:"grpc"` + API string `yaml:"api"` + Frontend string `yaml:"frontend"` + DevUI string `yaml:"dev-ui"` } // Parse parses config.yml into UserConfig. From c66c6fe5f3066c12f4722af51c1b660c11df559f Mon Sep 17 00:00:00 2001 From: ltacker Date: Wed, 10 Mar 2021 16:00:19 +0100 Subject: [PATCH 2/6] Change all references --- integration/env_test.go | 24 ++++++++++----------- integration/tx_test.go | 8 +++---- starport/services/chain/chain.go | 4 ++-- starport/services/chain/faucet.go | 2 +- starport/services/chain/plugin-launchpad.go | 8 +++---- starport/services/chain/plugin-stargate.go | 12 +++++------ starport/services/chain/serve.go | 24 ++++++++++----------- 7 files changed, 41 insertions(+), 41 deletions(-) diff --git a/integration/env_test.go b/integration/env_test.go index 23494d6272..e3a170cdcd 100644 --- a/integration/env_test.go +++ b/integration/env_test.go @@ -221,9 +221,9 @@ func (e env) EnsureAppIsSteady(appPath string) { // IsAppServed checks that app is served properly and servers are started to listening // before ctx canceled. -func (e env) IsAppServed(ctx context.Context, servers starportconf.Servers) error { +func (e env) IsAppServed(ctx context.Context, host starportconf.Host) error { checkAlive := func() error { - ok, err := httpstatuschecker.Check(ctx, xurl.HTTP(servers.APIAddr)+"/node_info") + ok, err := httpstatuschecker.Check(ctx, xurl.HTTP(host.API)+"/node_info") if err == nil && !ok { err = errors.New("app is not online") } @@ -242,7 +242,7 @@ func (e env) TmpDir() (path string) { // RandomizeServerPorts randomizes server ports for the app at path, updates // its config.yml and returns new values. -func (e env) RandomizeServerPorts(path string, configFile string) starportconf.Servers { +func (e env) RandomizeServerPorts(path string, configFile string) starportconf.Host { if configFile == "" { configFile = "config.yml" } @@ -255,14 +255,14 @@ func (e env) RandomizeServerPorts(path string, configFile string) starportconf.S return fmt.Sprintf("localhost:%d", port) } - servers := starportconf.Servers{ - RPCAddr: genAddr(ports[0]), - P2PAddr: genAddr(ports[1]), - ProfAddr: genAddr(ports[2]), - GRPCAddr: genAddr(ports[3]), - APIAddr: genAddr(ports[4]), - FrontendAddr: genAddr(ports[5]), - DevUIAddr: genAddr(ports[6]), + servers := starportconf.Host{ + RPC: genAddr(ports[0]), + P2P: genAddr(ports[1]), + Prof: genAddr(ports[2]), + GRPC: genAddr(ports[3]), + API: genAddr(ports[4]), + Frontend: genAddr(ports[5]), + DevUI: genAddr(ports[6]), } // update config.yml with the generated servers list. @@ -273,7 +273,7 @@ func (e env) RandomizeServerPorts(path string, configFile string) starportconf.S var conf starportconf.Config require.NoError(e.t, yaml.NewDecoder(configyml).Decode(&conf)) - conf.Servers = servers + conf.Host = servers require.NoError(e.t, configyml.Truncate(0)) _, err = configyml.Seek(0, 0) require.NoError(e.t, err) diff --git a/integration/tx_test.go b/integration/tx_test.go index 6d6b7b322e..14b5f63b16 100644 --- a/integration/tx_test.go +++ b/integration/tx_test.go @@ -23,7 +23,7 @@ func TestGetTxViaGRPCGateway(t *testing.T) { env = newEnv(t) appname = randstr.Runes(10) path = env.Scaffold(appname, Stargate) - servers = env.RandomizeServerPorts(path, "") + host = env.RandomizeServerPorts(path, "") ctx, cancel = context.WithCancel(env.Ctx()) ) @@ -57,7 +57,7 @@ func TestGetTxViaGRPCGateway(t *testing.T) { ), step.PreExec(func() error { output.Reset() - return env.IsAppServed(ctx, servers) + return env.IsAppServed(ctx, host) }), step.PostExec(func(execErr error) error { if execErr != nil { @@ -96,7 +96,7 @@ func TestGetTxViaGRPCGateway(t *testing.T) { "10token", "--keyring-backend", "test", "--chain-id", appname, - "--node", xurl.TCP(servers.RPCAddr), + "--node", xurl.TCP(host.RPC), "--yes", ), step.PreExec(func() error { @@ -115,7 +115,7 @@ func TestGetTxViaGRPCGateway(t *testing.T) { return err } - addr := fmt.Sprintf("%s/cosmos/tx/v1beta1/txs/%s", xurl.HTTP(servers.APIAddr), tx.Hash) + addr := fmt.Sprintf("%s/cosmos/tx/v1beta1/txs/%s", xurl.HTTP(host.API), tx.Hash) req, err := http.NewRequestWithContext(ctx, http.MethodGet, addr, nil) if err != nil { return errors.Wrap(err, "call to get tx via gRPC gateway") diff --git a/starport/services/chain/chain.go b/starport/services/chain/chain.go index 923a7600ab..7ef27492d0 100644 --- a/starport/services/chain/chain.go +++ b/starport/services/chain/chain.go @@ -201,7 +201,7 @@ func (c *Chain) RPCPublicAddress() (string, error) { if err != nil { return "", err } - rpcAddress = conf.Servers.RPCAddr + rpcAddress = conf.Host.RPC } return rpcAddress, nil } @@ -423,7 +423,7 @@ func (c *Chain) Commands(ctx context.Context) (chaincmdrunner.Runner, error) { chaincmd.WithChainID(id), chaincmd.WithHome(home), chaincmd.WithVersion(c.Version), - chaincmd.WithNodeAddress(xurl.TCP(config.Servers.RPCAddr)), + chaincmd.WithNodeAddress(xurl.TCP(config.Host.RPC)), } if c.plugin.Version() == cosmosver.Launchpad { diff --git a/starport/services/chain/faucet.go b/starport/services/chain/faucet.go index 5fafe36c67..d0fdb13f51 100644 --- a/starport/services/chain/faucet.go +++ b/starport/services/chain/faucet.go @@ -55,7 +55,7 @@ func (c *Chain) Faucet(ctx context.Context) (cosmosfaucet.Faucet, error) { } // construct faucet options. - apiAddress := conf.Servers.APIAddr + apiAddress := conf.Host.API if envAPIAddress != "" { apiAddress = envAPIAddress } diff --git a/starport/services/chain/plugin-launchpad.go b/starport/services/chain/plugin-launchpad.go index 98a17455e5..c966582141 100644 --- a/starport/services/chain/plugin-launchpad.go +++ b/starport/services/chain/plugin-launchpad.go @@ -88,9 +88,9 @@ func (p *launchpadPlugin) configtoml(homePath string, conf starportconf.Config) return err } config.Set("rpc.cors_allowed_origins", []string{"*"}) - config.Set("rpc.laddr", xurl.TCP(conf.Servers.RPCAddr)) - config.Set("p2p.laddr", xurl.TCP(conf.Servers.P2PAddr)) - config.Set("rpc.pprof_laddr", conf.Servers.ProfAddr) + config.Set("rpc.laddr", xurl.TCP(conf.Host.RPC)) + config.Set("p2p.laddr", xurl.TCP(conf.Host.P2P)) + config.Set("rpc.pprof_laddr", conf.Host.Prof) file, err := os.OpenFile(path, os.O_RDWR|os.O_TRUNC, 0644) if err != nil { return err @@ -109,7 +109,7 @@ func (p *launchpadPlugin) Start(ctx context.Context, runner chaincmdrunner.Runne }) g.Go(func() error { - err := runner.LaunchpadStartRestServer(ctx, xurl.TCP(conf.Servers.APIAddr), xurl.TCP(conf.Servers.RPCAddr)) + err := runner.LaunchpadStartRestServer(ctx, xurl.TCP(conf.Host.API), xurl.TCP(conf.Host.RPC)) return errors.Wrapf(err, "cannot run %[1]vcli rest-server", p.app.Name) }) diff --git a/starport/services/chain/plugin-stargate.go b/starport/services/chain/plugin-stargate.go index faea0bb9bc..a0b5fbc7c3 100644 --- a/starport/services/chain/plugin-stargate.go +++ b/starport/services/chain/plugin-stargate.go @@ -68,8 +68,8 @@ func (p *stargatePlugin) apptoml(homePath string, conf starportconf.Config) erro config.Set("api.enable", true) config.Set("api.enabled-unsafe-cors", true) config.Set("rpc.cors_allowed_origins", []string{"*"}) - config.Set("api.address", xurl.TCP(conf.Servers.APIAddr)) - config.Set("grpc.address", conf.Servers.GRPCAddr) + config.Set("api.address", xurl.TCP(conf.Host.API)) + config.Set("grpc.address", conf.Host.GRPC) file, err := os.OpenFile(path, os.O_RDWR|os.O_TRUNC, 0644) if err != nil { return err @@ -89,9 +89,9 @@ func (p *stargatePlugin) configtoml(homePath string, conf starportconf.Config) e config.Set("rpc.cors_allowed_origins", []string{"*"}) config.Set("consensus.timeout_commit", "1s") config.Set("consensus.timeout_propose", "1s") - config.Set("rpc.laddr", xurl.TCP(conf.Servers.RPCAddr)) - config.Set("p2p.laddr", xurl.TCP(conf.Servers.P2PAddr)) - config.Set("rpc.pprof_laddr", conf.Servers.ProfAddr) + config.Set("rpc.laddr", xurl.TCP(conf.Host.RPC)) + config.Set("p2p.laddr", xurl.TCP(conf.Host.P2P)) + config.Set("rpc.pprof_laddr", conf.Host.Prof) file, err := os.OpenFile(path, os.O_RDWR|os.O_TRUNC, 0644) if err != nil { return err @@ -106,7 +106,7 @@ func (p *stargatePlugin) Start(ctx context.Context, runner chaincmdrunner.Runner "--pruning", "nothing", "--grpc.address", - conf.Servers.GRPCAddr, + conf.Host.GRPC, ) return &CannotStartAppError{p.app.Name, err} } diff --git a/starport/services/chain/serve.go b/starport/services/chain/serve.go index fd78c98d96..ad9b136c96 100644 --- a/starport/services/chain/serve.go +++ b/starport/services/chain/serve.go @@ -459,14 +459,14 @@ func (c *Chain) start(ctx context.Context, conf conf.Config) error { c.served = true // print the server addresses. - fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a Cosmos '%[1]v' app with Tendermint at %s.\n", c.app.Name, xurl.HTTP(conf.Servers.RPCAddr)) - fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a server at %s (LCD)\n", xurl.HTTP(conf.Servers.APIAddr)) + fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a Cosmos '%[1]v' app with Tendermint at %s.\n", c.app.Name, xurl.HTTP(conf.Host.RPC)) + fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a server at %s (LCD)\n", xurl.HTTP(conf.Host.API)) if isFaucetEnabled { fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a faucet at http://0.0.0.0:%d\n", conf.Faucet.Port) } - fmt.Fprintf(c.stdLog(logStarport).out, "\nšŸš€ Get started: %s\n\n", xurl.HTTP(conf.Servers.DevUIAddr)) + fmt.Fprintf(c.stdLog(logStarport).out, "\nšŸš€ Get started: %s\n\n", xurl.HTTP(conf.Host.DevUI)) return g.Wait() } @@ -489,7 +489,7 @@ func (c *Chain) watchAppFrontend(ctx context.Context) error { } return nil // ignore errors. } - host, port, err := net.SplitHostPort(conf.Servers.FrontendAddr) + host, port, err := net.SplitHostPort(conf.Host.Frontend) if err != nil { return err } @@ -508,9 +508,9 @@ func (c *Chain) watchAppFrontend(ctx context.Context) error { step.Env( fmt.Sprintf("HOST=%s", host), fmt.Sprintf("PORT=%s", port), - fmt.Sprintf("VUE_APP_API_COSMOS=%s", xurl.HTTP(conf.Servers.APIAddr)), - fmt.Sprintf("VUE_APP_API_TENDERMINT=%s", xurl.HTTP(conf.Servers.RPCAddr)), - fmt.Sprintf("VUE_APP_WS_TENDERMINT=%s/websocket", xurl.WS(conf.Servers.RPCAddr)), + fmt.Sprintf("VUE_APP_API_COSMOS=%s", xurl.HTTP(conf.Host.API)), + fmt.Sprintf("VUE_APP_API_TENDERMINT=%s", xurl.HTTP(conf.Host.RPC)), + fmt.Sprintf("VUE_APP_WS_TENDERMINT=%s/websocket", xurl.WS(conf.Host.RPC)), ), step.PostExec(postExec), ), @@ -523,7 +523,7 @@ func (c *Chain) runDevServer(ctx context.Context) error { return err } - grpcconn, grpcHandler, err := newGRPCWebProxyHandler(config.Servers.GRPCAddr) + grpcconn, grpcHandler, err := newGRPCWebProxyHandler(config.Host.GRPC) if err != nil { return err } @@ -531,9 +531,9 @@ func (c *Chain) runDevServer(ctx context.Context) error { conf := Config{ SdkVersion: c.plugin.Name(), - EngineAddr: xurl.HTTP(config.Servers.RPCAddr), - AppBackendAddr: xurl.HTTP(config.Servers.APIAddr), - AppFrontendAddr: xurl.HTTP(config.Servers.FrontendAddr), + EngineAddr: xurl.HTTP(config.Host.RPC), + AppBackendAddr: xurl.HTTP(config.Host.API), + AppFrontendAddr: xurl.HTTP(config.Host.Frontend), } // TODO get vals from const handler, err := newDevHandler(c.app, conf, grpcHandler) if err != nil { @@ -541,7 +541,7 @@ func (c *Chain) runDevServer(ctx context.Context) error { } return xhttp.Serve(ctx, &http.Server{ - Addr: config.Servers.DevUIAddr, + Addr: config.Host.DevUI, Handler: handler, }) } From f2efc16e8f79734fe7dced1ebf001482f7420961 Mon Sep 17 00:00:00 2001 From: ltacker Date: Wed, 10 Mar 2021 17:39:40 +0100 Subject: [PATCH 3/6] faucet host option --- integration/tx_test.go | 2 +- starport/chainconf/config.go | 11 +++++++---- starport/services/chain/serve.go | 14 ++++++++++++-- 3 files changed, 20 insertions(+), 7 deletions(-) diff --git a/integration/tx_test.go b/integration/tx_test.go index 14b5f63b16..557791622f 100644 --- a/integration/tx_test.go +++ b/integration/tx_test.go @@ -23,7 +23,7 @@ func TestGetTxViaGRPCGateway(t *testing.T) { env = newEnv(t) appname = randstr.Runes(10) path = env.Scaffold(appname, Stargate) - host = env.RandomizeServerPorts(path, "") + host = env.RandomizeServerPorts(path, "") ctx, cancel = context.WithCancel(env.Ctx()) ) diff --git a/starport/chainconf/config.go b/starport/chainconf/config.go index 8cb011bb60..6403ab174d 100644 --- a/starport/chainconf/config.go +++ b/starport/chainconf/config.go @@ -39,7 +39,7 @@ var ( }, }, Faucet: Faucet{ - Port: 4500, + Host: ":4500", }, } ) @@ -101,9 +101,6 @@ type Proto struct { // Faucet configuration. type Faucet struct { - // Port number for faucet server to listen at. - Port int `yaml:"port"` - // Name is faucet account's name. Name *string `yaml:"name"` @@ -113,6 +110,12 @@ type Faucet struct { // CoinsMax holds of chain denoms and their max amounts that can be transferred // to single user. CoinsMax []string `yaml:"coins_max"` + + // Host is the host of the faucet server + Host string `yaml:"host"` + + // Port number for faucet server to listen at. + Port int `yaml:"port"` } // Init overwrites sdk configurations with given values. diff --git a/starport/services/chain/serve.go b/starport/services/chain/serve.go index ad9b136c96..ddce737006 100644 --- a/starport/services/chain/serve.go +++ b/starport/services/chain/serve.go @@ -462,8 +462,13 @@ func (c *Chain) start(ctx context.Context, conf conf.Config) error { fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a Cosmos '%[1]v' app with Tendermint at %s.\n", c.app.Name, xurl.HTTP(conf.Host.RPC)) fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a server at %s (LCD)\n", xurl.HTTP(conf.Host.API)) + host := conf.Faucet.Host + if host == "" { + host = fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port) + } + if isFaucetEnabled { - fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a faucet at http://0.0.0.0:%d\n", conf.Faucet.Port) + fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a faucet at http://%s\n", host) } fmt.Fprintf(c.stdLog(logStarport).out, "\nšŸš€ Get started: %s\n\n", xurl.HTTP(conf.Host.DevUI)) @@ -552,8 +557,13 @@ func (c *Chain) runFaucetServer(ctx context.Context, faucet cosmosfaucet.Faucet) return err } + host := conf.Faucet.Host + if host == "" { + host = fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port) + } + return xhttp.Serve(ctx, &http.Server{ - Addr: fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port), + Addr: host, Handler: faucet, }) } From e94b428a1c4856cf101463d9afc8d8d1cec632a8 Mon Sep 17 00:00:00 2001 From: ltacker Date: Wed, 10 Mar 2021 17:50:08 +0100 Subject: [PATCH 4/6] Fix default port --- starport/chainconf/config.go | 2 +- starport/services/chain/serve.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/starport/chainconf/config.go b/starport/chainconf/config.go index 6403ab174d..45ea76bd27 100644 --- a/starport/chainconf/config.go +++ b/starport/chainconf/config.go @@ -39,7 +39,7 @@ var ( }, }, Faucet: Faucet{ - Host: ":4500", + Host: "0.0.0.0:4500", }, } ) diff --git a/starport/services/chain/serve.go b/starport/services/chain/serve.go index ddce737006..11954ef090 100644 --- a/starport/services/chain/serve.go +++ b/starport/services/chain/serve.go @@ -463,7 +463,7 @@ func (c *Chain) start(ctx context.Context, conf conf.Config) error { fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a server at %s (LCD)\n", xurl.HTTP(conf.Host.API)) host := conf.Faucet.Host - if host == "" { + if conf.Faucet.Port != 0 { host = fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port) } @@ -558,7 +558,7 @@ func (c *Chain) runFaucetServer(ctx context.Context, faucet cosmosfaucet.Faucet) } host := conf.Faucet.Host - if host == "" { + if conf.Faucet.Port != 0 { host = fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port) } From b10e59b1d45c3a05ee815506484201cd87a5b0f0 Mon Sep 17 00:00:00 2001 From: ltacker Date: Thu, 11 Mar 2021 09:32:30 +0100 Subject: [PATCH 5/6] Ilker comments --- starport/chainconf/config.go | 14 ++++++++- starport/chainconf/config_test.go | 52 +++++++++++++++++++++++++++++++ starport/services/chain/serve.go | 26 +++++----------- 3 files changed, 73 insertions(+), 19 deletions(-) diff --git a/starport/chainconf/config.go b/starport/chainconf/config.go index 45ea76bd27..d53f53b4a3 100644 --- a/starport/chainconf/config.go +++ b/starport/chainconf/config.go @@ -39,7 +39,7 @@ var ( }, }, Faucet: Faucet{ - Host: "0.0.0.0:4500", + Host: ":4500", }, } ) @@ -201,3 +201,15 @@ func LocateDefault(root string) (path string, err error) { } return "", ErrCouldntLocateConfig } + +// FaucetHost returns the faucet host to use +func FaucetHost(conf Config) (string) { + // We keep supporting Port option for backward compatibility + // TODO: drop this option in the future + host := conf.Faucet.Host + if conf.Faucet.Port != 0 { + host = fmt.Sprintf(":%d", conf.Faucet.Port) + } + + return host +} \ No newline at end of file diff --git a/starport/chainconf/config_test.go b/starport/chainconf/config_test.go index 48a553b43a..d6862bfb09 100644 --- a/starport/chainconf/config_test.go +++ b/starport/chainconf/config_test.go @@ -49,3 +49,55 @@ accounts: _, err := Parse(strings.NewReader(confyml)) require.Equal(t, &ValidationError{"validator is required"}, err) } + +func TestFaucetHost(t *testing.T) { + confyml := ` +accounts: + - name: me + coins: ["1000token", "100000000stake"] + - name: you + coins: ["5000token"] +validator: + name: user1 + staked: "100000000stake" +faucet: + host: "0.0.0.0:4600" +` + conf, err := Parse(strings.NewReader(confyml)) + require.NoError(t, err) + require.Equal(t, "0.0.0.0:4600", FaucetHost(conf)) + + confyml = ` +accounts: + - name: me + coins: ["1000token", "100000000stake"] + - name: you + coins: ["5000token"] +validator: + name: user1 + staked: "100000000stake" +faucet: + port: 4700 +` + conf, err = Parse(strings.NewReader(confyml)) + require.NoError(t, err) + require.Equal(t, ":4700", FaucetHost(conf)) + + // Port must be higher priority + confyml = ` +accounts: + - name: me + coins: ["1000token", "100000000stake"] + - name: you + coins: ["5000token"] +validator: + name: user1 + staked: "100000000stake" +faucet: + host: "0.0.0.0:4600" + port: 4700 +` + conf, err = Parse(strings.NewReader(confyml)) + require.NoError(t, err) + require.Equal(t, ":4700", FaucetHost(conf)) +} \ No newline at end of file diff --git a/starport/services/chain/serve.go b/starport/services/chain/serve.go index 11954ef090..8c8243575a 100644 --- a/starport/services/chain/serve.go +++ b/starport/services/chain/serve.go @@ -424,7 +424,7 @@ func (c *Chain) serve(ctx context.Context, forceReset bool) error { return c.start(ctx, conf) } -func (c *Chain) start(ctx context.Context, conf conf.Config) error { +func (c *Chain) start(ctx context.Context, config conf.Config) error { commands, err := c.Commands(ctx) if err != nil { return err @@ -433,7 +433,7 @@ func (c *Chain) start(ctx context.Context, conf conf.Config) error { g, ctx := errgroup.WithContext(ctx) // start the blockchain. - g.Go(func() error { return c.plugin.Start(ctx, commands, conf) }) + g.Go(func() error { return c.plugin.Start(ctx, commands, config) }) // start the faucet if enabled. faucet, err := c.Faucet(ctx) @@ -459,19 +459,14 @@ func (c *Chain) start(ctx context.Context, conf conf.Config) error { c.served = true // print the server addresses. - fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a Cosmos '%[1]v' app with Tendermint at %s.\n", c.app.Name, xurl.HTTP(conf.Host.RPC)) - fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a server at %s (LCD)\n", xurl.HTTP(conf.Host.API)) - - host := conf.Faucet.Host - if conf.Faucet.Port != 0 { - host = fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port) - } + fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a Cosmos '%[1]v' app with Tendermint at %s.\n", c.app.Name, xurl.HTTP(config.Host.RPC)) + fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a server at %s (LCD)\n", xurl.HTTP(config.Host.API)) if isFaucetEnabled { - fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a faucet at http://%s\n", host) + fmt.Fprintf(c.stdLog(logStarport).out, "šŸŒ Running a faucet at http://%s\n", conf.FaucetHost(config)) } - fmt.Fprintf(c.stdLog(logStarport).out, "\nšŸš€ Get started: %s\n\n", xurl.HTTP(conf.Host.DevUI)) + fmt.Fprintf(c.stdLog(logStarport).out, "\nšŸš€ Get started: %s\n\n", xurl.HTTP(config.Host.DevUI)) return g.Wait() } @@ -552,18 +547,13 @@ func (c *Chain) runDevServer(ctx context.Context) error { } func (c *Chain) runFaucetServer(ctx context.Context, faucet cosmosfaucet.Faucet) error { - conf, err := c.Config() + config, err := c.Config() if err != nil { return err } - host := conf.Faucet.Host - if conf.Faucet.Port != 0 { - host = fmt.Sprintf("0.0.0.0:%d", conf.Faucet.Port) - } - return xhttp.Serve(ctx, &http.Server{ - Addr: host, + Addr: conf.FaucetHost(config), Handler: faucet, }) } From ba096810cc12a1ac908ffdd8686507392e749b6f Mon Sep 17 00:00:00 2001 From: ltacker Date: Thu, 11 Mar 2021 09:36:38 +0100 Subject: [PATCH 6/6] Lint --- starport/chainconf/config.go | 4 ++-- starport/chainconf/config_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/starport/chainconf/config.go b/starport/chainconf/config.go index d53f53b4a3..14e40ea2da 100644 --- a/starport/chainconf/config.go +++ b/starport/chainconf/config.go @@ -203,7 +203,7 @@ func LocateDefault(root string) (path string, err error) { } // FaucetHost returns the faucet host to use -func FaucetHost(conf Config) (string) { +func FaucetHost(conf Config) string { // We keep supporting Port option for backward compatibility // TODO: drop this option in the future host := conf.Faucet.Host @@ -212,4 +212,4 @@ func FaucetHost(conf Config) (string) { } return host -} \ No newline at end of file +} diff --git a/starport/chainconf/config_test.go b/starport/chainconf/config_test.go index d6862bfb09..57bdf7a888 100644 --- a/starport/chainconf/config_test.go +++ b/starport/chainconf/config_test.go @@ -100,4 +100,4 @@ faucet: conf, err = Parse(strings.NewReader(confyml)) require.NoError(t, err) require.Equal(t, ":4700", FaucetHost(conf)) -} \ No newline at end of file +}