Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-1699 revisited #1346

Merged
merged 2 commits into from Apr 30, 2019
Merged

OF-1699 revisited #1346

merged 2 commits into from Apr 30, 2019

Conversation

GregDThomas
Copy link
Contributor

During testing of split brain recovery (igniterealtime/openfire-hazelcast-plugin#23) it became clear that the cluster monitoring introduced in #1332 had two (minor) flaws;

  • When the junior node loses network connectivity, it attempts to send a message as it is now senior; this message can be stored in the DB, which may also be inaccessible. This all takes some time (a few seconds) to fail. To avoid slowing down the (synchronous) raising of ClusterEventListener events the sending of messages is now done in a background thread.
  • Ensure existing remote node names are cached when the local node joins the cluster, as well as when new remote nodes join.

@GregDThomas GregDThomas requested a review from guusdk April 24, 2019 09:40
@GregDThomas
Copy link
Contributor Author

@guusdk tagging you on this as it subtly changes the behaviour of UpdateManager too - this will make the admin messages it sends be sent asynchronously, but don't think that's any cause for worry..

@GregDThomas
Copy link
Contributor Author

Now re-based

@akrherz akrherz merged commit 6b12d18 into igniterealtime:master Apr 30, 2019
@GregDThomas GregDThomas deleted the OF-1699-bis branch December 8, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants