Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-1903 Support for @WebServlet annotation #1487

Merged

Conversation

@GregDThomas
Copy link
Contributor

GregDThomas commented Sep 21, 2019

This allows admin servlets to be tagged with the @WebServlet annotation instead of the arcane settings in the web.xml file. Lack of support has been bugging me a while, and it wasn't until I came across https://stackoverflow.com/a/26220672/359394 by accident did I come back to it.

PS. Happy to raise an issue to cover this off if people think it's worth while
PPS. It may be possible to replace further entries in web.xml with appropriate annotations, but baby steps ...
PPS. Would also like to introduce something similar for plugin servlets, but that may have to wait for another day

@akrherz akrherz changed the title Support for @WebServlet annotation OF-1903 Support for @WebServlet annotation Oct 27, 2019
@akrherz akrherz merged commit 682c661 into igniterealtime:master Oct 27, 2019
3 checks passed
3 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@IgniteRealtime-Bot

This comment has been minimized.

Copy link

IgniteRealtime-Bot commented Nov 4, 2019

This pull request has been mentioned on Ignite Realtime Community Forums. There might be relevant details there:

https://discourse.igniterealtime.org/t/http-404-security-audit-viewer-jsp/86542/7

@GregDThomas GregDThomas deleted the GregDThomas:webservlet-annotation-support branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.