Permalink
Show file tree
Hide file tree
8 changes: 8 additions & 0 deletions
8
smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java
11 changes: 1 addition & 10 deletions
11
smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java
1 comment
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Move TLS Required check at the end of connect()
It was a *very* bad idea to perform the SecurityMode.Required check in the connection's reader thread and not at the end of AbstractXMPPConnectin's connect(). :/ This behavior dates back to 8e75091 Fixes SMACK-739
- Loading branch information
Showing
2 changed files
with
9 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9d5cd4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Flowdalic The issue SMACK-739 isn't listed here: https://issues.igniterealtime.org/projects/SMACK/issues/
Can you add the issue to the list or just explain what issue fixes this commit?