Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.1 fails (unless used on root context). #12

Closed
Dehumanizer77 opened this issue Nov 7, 2019 · 10 comments

Comments

@Dehumanizer77
Copy link

@Dehumanizer77 Dehumanizer77 commented Nov 7, 2019

I have just upgraded httpFileUpload plugin to version 1.1.1 and it has stopped working. When trying to send an image, I'm just getting "delivery failed" every time. After switching back to 1.1.0, everything works again.
Client I was testing it with is Conversations version 2.5.12+pcr (on Android 9)

@wrooot

This comment has been minimized.

Copy link
Member

@wrooot wrooot commented Nov 7, 2019

Server version?

@fuxuan928

This comment has been minimized.

Copy link

@fuxuan928 fuxuan928 commented Nov 8, 2019

same Openfire 4.4.3
the PUT is https://xxx.com/{guid}/xxx.zip, no /httpfileupload in it.

@wrooot

This comment has been minimized.

Copy link
Member

@wrooot wrooot commented Nov 8, 2019

Ugh, Spark stops working every time plugin updates. So i don't have a mean to test this locally (can't connect with Conversations to my local server, Gajim also doesn't want to send file because of a self-signed cert).

@guusdk @akrherz is this plugin updated on ignite server? Then we might be able to test it with Conv/Gajim.

@akrherz

This comment has been minimized.

Copy link
Member

@akrherz akrherz commented Nov 8, 2019

@akrherz is this plugin updated on ignite server?

I have updated it now.

@wrooot

This comment has been minimized.

Copy link
Member

@wrooot wrooot commented Nov 8, 2019

Failing to upload in both xabber and conv

@fenuz

This comment has been minimized.

Copy link

@fenuz fenuz commented Nov 11, 2019

+1

It seems that the advertised URL is not the url the webapp is mounted at (/httpfileupload). The advertised URL's are in the /uuid/filename.extension format. The old httpfileuploadcomponent (1.1.3) had an endpoint set to Component, which was used as the slot URL prefix, the new (1.2.0) version does not have such a construct.

I am under the impression that the 1.1.1 version of this plugin does not work at all, or am I missing a workaround? Perhaps its best to remove the plugin download from the openfire plugin downloads while this gets fixed.

@wrooot

This comment has been minimized.

Copy link
Member

@wrooot wrooot commented Nov 11, 2019

It looks like it doesn't work indeed.

@guusdk guusdk changed the title 1.1.1 not working Release 1.1.1 fails (unless used on root context). Nov 12, 2019
@guusdk

This comment has been minimized.

Copy link
Member

@guusdk guusdk commented Nov 12, 2019

Yeah, my bad. Release 1.1.1 appears to functioning only if it's being ran through a reverse proxy of sorts, mapping the endpoint context to a root context of a domain. I'll resolve this shortly.

guusdk added a commit to guusdk/openfire-httpFileUpload-plugin that referenced this issue Nov 12, 2019
The URL on which the service is exposed should, by default, match the one that's used by Openfire.
@guusdk guusdk closed this in cc2e5fc Nov 12, 2019
@guusdk guusdk mentioned this issue Nov 12, 2019
@Dehumanizer77

This comment has been minimized.

Copy link
Author

@Dehumanizer77 Dehumanizer77 commented Nov 12, 2019

Still not working. Plus the server behaves very strangely when I install 1.1.1-SNAPSHOT. Messages not getting sent/received randomly, I had to remove the plugin completely and also restart openfire completely to put it back to normal. Then installed 1.1.0 back and again everything is working. I have tried it several times.
Server version 4.4.3
Sorry for not responding earlier but for some reason I didn't get an email notification from github until the issue had been closed.

@guusdk

This comment has been minimized.

Copy link
Member

@guusdk guusdk commented Nov 12, 2019

1.1.1-SNAPSHOT is not expected to fix this. This should be fixed in 1.1.2, which was released moments ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.