Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addressing when original request has no 'to' attribute. #27

Closed
wrooot opened this issue Jan 18, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@wrooot
Copy link
Member

commented Jan 18, 2019

User reports that Gajim client can't retrieve new history messages from the archive since 4.3.0 update. As reported it was the same with 4.3.0 and 1.6.2 version of plugin. And it was working ok with 4.2.3.

1.7.0 update of the plugin fixed issues in Conversations and this client can retrieve new messages, but Gajim can't.

@wrooot

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

image

@wrooot

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

image

@wrooot

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

@guusdk

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

Here's another trace. Note how the request has no 'to' (which, according to https://xmpp.org/rfcs/rfc6120.html#rules-noto is to be interpreted as 'handle on behalf of the sender'). Our response, however, is from the domain, not the 'from' address.

This seems to be introduced by OF-1644

<!-- Outgoing 23.01.2019 20:09:25 -->
<iq xmlns="jabber:client" type="set" id="2bca788d-69d5-4ee6-b3db-e99221fed2fd" from="lovetox@softjoys.pro/gajim.PH3XIREU">
<query xmlns="urn:xmpp:mam:1" queryid="d2985858-49fc-4409-ab50-fa9a9856974f">
<x xmlns="jabber:x:data" type="submit">
<field var="FORM_TYPE" type="hidden">
<value>urn:xmpp:mam:1</value>
</field>
<field var="start" type="text-single">
<value>2019-01-16T19:09:24Z</value>
</field>
</x>
<set xmlns="http://jabber.org/protocol/rsm">
<max>70</max>
</set>
</query>
</iq>


<!-- Incoming 23.01.2019 20:09:25 -->
<iq xmlns="jabber:client" type="result" id="2bca788d-69d5-4ee6-b3db-e99221fed2fd" from="softjoys.pro" to="lovetox@softjoys.pro/gajim.PH3XIREU">
<fin xmlns="urn:xmpp:mam:1" queryid="d2985858-49fc-4409-ab50-fa9a9856974f" complete="true">
<set xmlns="http://jabber.org/protocol/rsm">
<count>0</count>
</set>
</fin>
</iq>

@guusdk guusdk closed this in #28 Jan 23, 2019

@wrooot wrooot changed the title Gajim not able to get archived messages since 4.3.0 update Fix addressing when original request has no 'to' attribute. Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.