Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge forward msgs5 to master #71

Merged
merged 40 commits into from Jul 10, 2020
Merged

Merge forward msgs5 to master #71

merged 40 commits into from Jul 10, 2020

Conversation

j-rivero
Copy link
Contributor

No description provided.

chapulina and others added 30 commits December 20, 2019 16:59
Ignore deprecation warnings on generated code

Approved-by: Steve Peters <scpeters@osrfoundation.org>
Handle empty xml elements

Approved-by: Louise Poubel <lupoubel@hotmail.com>
Add sdf_generator_config

Approved-by: Louise Poubel <lupoubel@hotmail.com>
Bump to 4.8.0

Approved-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
Signed-off-by: claireyywang <clairewang@openrobotics.org>
[ign-msgs4] Update BitBucket links

Signed-off-by: Louise Poubel <louise@openrobotics.org>
* [ign-msgs5] Update BitBucket links

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* [ign-msgs5] Update BitBucket links

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* [ign-msgs5] Update BitBucket links

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
chapulina and others added 10 commits May 8, 2020 07:48
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
* Add CMake options to support cross-compilation

This commit adds two CMake options:
* INSTALL_IGN_MSGS_GEN_EXECUTABLE if this option is enabled, the
  ign_msgs_gen protobuf executable plugin is also installed, so
  that this option can be enabled in host builds to permit
  cross-compilation builds to use it to generate the messages.
  As this executable is not side by side installable with other
  ignition-msgs installations with different major versions and is an
  advanced option meant just for packaging, by default it is set to OFF.
* IGN_MSGS_GEN_EXECUTABLE: this string variable can be set to
  have ign-msgs use a ign_msgs_gen executable plugin that was not
  build by the project, to enable cross-compilation scenarios.

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>

* Add docs on cross-compilation

Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
@j-rivero j-rivero requested a review from caguero as a code owner July 10, 2020 16:02
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jul 10, 2020
@osrf-triage osrf-triage added this to Inbox in Core development Jul 10, 2020
@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #71 into master will decrease coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   85.98%   85.66%   -0.33%     
==========================================
  Files           7        7              
  Lines         792      795       +3     
==========================================
  Hits          681      681              
- Misses        111      114       +3     
Impacted Files Coverage Δ
src/Utility.cc 83.47% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae7b89...8088dbe. Read the comment docs.

Core development automation moved this from Inbox to In review Jul 10, 2020
@chapulina chapulina merged commit 9d7791a into master Jul 10, 2020
Core development automation moved this from In review to Done Jul 10, 2020
@chapulina chapulina deleted the merge_5_to_6 branch July 10, 2020 21:09
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants